public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Greg Schafer <gschafer@zip.com.au>
To: Jakub Jelinek <jakub@redhat.com>
Cc: binutils@sources.redhat.com
Subject: Re: [PATCH] Re: ld testsuite breaks with latest GCC-4.0
Date: Tue, 04 Jan 2005 22:47:00 -0000	[thread overview]
Message-ID: <20050104224730.GA20987@tigers-lfs.nsw.bigpond.net.au> (raw)
In-Reply-To: <20050104104326.GR3168@sunsite.mff.cuni.cz>

On Tue, Jan 04, 2005 at 11:43:26AM +0100, Jakub Jelinek wrote:

> If there is a specs file, configure.host should use that and only use
> -dumpspecs if it is not present.
> -dumpspecs dumps the built-in specs, not the ones it finds on the
> filesystem.
> This can make a difference if specs is hand edited.

Agreed. That is the exact scenario I was concerned about and alluded to up
thread.

> So, I think the patch should use ${CC} --print-file-name=specs,
> if that prints just specs, it should use ${CC} -dumpspecs,
> otherwise cat the specs file.
>   specs=`${CC} --print-file-name=specs`
>   { if [ x"$specs" = xspecs ]; then ${CC} -dumpspecs; else cat "$specs"; fi; } \
>   | egrep ...

Yes. That would seem saner and definitely more robust. I'll try to make a
new patch and test it but am running short on time right now.. so if someone
beats me to it.. go right ahead. Also, prolly best to remove that ia64-aix cruft
as confirmed by Jim Wilson.

Thanks
Greg

  reply	other threads:[~2005-01-04 22:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-02  4:45 Greg Schafer
2005-01-02  5:11 ` Daniel Jacobowitz
2005-01-02  6:24   ` [PATCH] " Greg Schafer
2005-01-03 20:51     ` James E Wilson
2005-01-04 10:30     ` Nick Clifton
2005-01-04 10:43     ` Jakub Jelinek
2005-01-04 22:47       ` Greg Schafer [this message]
2005-01-06 12:25         ` Greg Schafer
2005-01-10 14:58           ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050104224730.GA20987@tigers-lfs.nsw.bigpond.net.au \
    --to=gschafer@zip.com.au \
    --cc=binutils@sources.redhat.com \
    --cc=jakub@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).