From: "H. J. Lu" <hjl@lucon.org>
To: binutils@sources.redhat.com
Subject: Re: PATCH: Minor readelf update
Date: Tue, 04 Jan 2005 23:36:00 -0000 [thread overview]
Message-ID: <20050104233638.GA558@lucon.org> (raw)
In-Reply-To: <20050104223930.GA31989@lucon.org>
On Tue, Jan 04, 2005 at 02:39:30PM -0800, H. J. Lu wrote:
> readelf outputs
>
> Contents of the .debug_str section:
>
> 0x00000000 5f5f6f66 665f7400 5f494f5f 72656164 __off_t._IO_read
> ...
> 0x00000240 74655f62 61736500 72657375 6c7400 te_base.result.
> Contents of the .debug_loc section:
>
> This patch adds a newline. I will check it in shortly.
>
This is the patch I will check in.
H.J.
----
2005-01-04 H.J. Lu <hongjiu.lu@intel.com>
* readelf.c (display_debug_loc): Display offsets for hole and
overlap.
(display_debug_str): Add a newline at the end.
--- readelf.c.orig 2005-01-04 14:30:34.096675262 -0800
+++ readelf.c 2005-01-04 15:32:39.487003629 -0800
@@ -9483,10 +9483,10 @@ display_debug_loc (Elf_Internal_Shdr *se
{
if (start < next)
warn (_("There is a hole [0x%lx - 0x%lx] in .debug_loc section.\n"),
- start, next);
+ start - section_begin, next - section_begin);
else if (start > next)
warn (_("There is an overlap [0x%lx - 0x%lx] in .debug_loc section.\n"),
- start, next);
+ start - section_begin, next - section_begin);
}
start = next;
@@ -9587,6 +9587,8 @@ display_debug_str (Elf_Internal_Shdr *se
bytes -= lbytes;
}
+ putchar ('\n');
+
return 1;
}
prev parent reply other threads:[~2005-01-04 23:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-04 22:39 PATCH H. J. Lu
2005-01-04 23:36 ` H. J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050104233638.GA558@lucon.org \
--to=hjl@lucon.org \
--cc=binutils@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).