public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* PATCH
@ 2005-01-04 22:39 H. J. Lu
  2005-01-04 23:36 ` PATCH: Minor readelf update H. J. Lu
  0 siblings, 1 reply; 2+ messages in thread
From: H. J. Lu @ 2005-01-04 22:39 UTC (permalink / raw)
  To: binutils

readelf outputs

Contents of the .debug_str section:

  0x00000000 5f5f6f66 665f7400 5f494f5f 72656164 __off_t._IO_read
...
  0x00000240 74655f62 61736500 72657375 6c7400   te_base.result.
Contents of the .debug_loc section:

This patch adds a newline. I will check it in shortly.

H.J.
---
2005-01-04  H.J. Lu  <hongjiu.lu@intel.com>

        * readelf.c (display_debug_str): Add a newline at the end.

--- readelf.c.foo	2005-01-04 14:24:23.965327362 -0800
+++ readelf.c	2005-01-04 14:29:38.519980569 -0800
@@ -9633,6 +9633,8 @@ display_debug_str (Elf_Internal_Shdr *se
       bytes -= lbytes;
     }
 
+  putchar ('\n');
+
   return 1;
 }
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: PATCH: Minor readelf update
  2005-01-04 22:39 PATCH H. J. Lu
@ 2005-01-04 23:36 ` H. J. Lu
  0 siblings, 0 replies; 2+ messages in thread
From: H. J. Lu @ 2005-01-04 23:36 UTC (permalink / raw)
  To: binutils

On Tue, Jan 04, 2005 at 02:39:30PM -0800, H. J. Lu wrote:
> readelf outputs
> 
> Contents of the .debug_str section:
> 
>   0x00000000 5f5f6f66 665f7400 5f494f5f 72656164 __off_t._IO_read
> ...
>   0x00000240 74655f62 61736500 72657375 6c7400   te_base.result.
> Contents of the .debug_loc section:
> 
> This patch adds a newline. I will check it in shortly.
> 

This is the patch I will check in.


H.J.
----
2005-01-04  H.J. Lu  <hongjiu.lu@intel.com>

        * readelf.c (display_debug_loc): Display offsets for hole and
        overlap.
        (display_debug_str): Add a newline at the end.
--- readelf.c.orig	2005-01-04 14:30:34.096675262 -0800
+++ readelf.c	2005-01-04 15:32:39.487003629 -0800
@@ -9483,10 +9483,10 @@ display_debug_loc (Elf_Internal_Shdr *se
 	    {
 	      if (start < next)
 		warn (_("There is a hole [0x%lx - 0x%lx] in .debug_loc section.\n"),
-		      start, next);
+		      start - section_begin, next - section_begin);
 	      else if (start > next)
 		warn (_("There is an overlap [0x%lx - 0x%lx] in .debug_loc section.\n"),
-		      start, next);
+		      start - section_begin, next - section_begin);
 	    }
 	  start = next;
 
@@ -9587,6 +9587,8 @@ display_debug_str (Elf_Internal_Shdr *se
       bytes -= lbytes;
     }
 
+  putchar ('\n');
+
   return 1;
 }
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-01-04 23:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-04 22:39 PATCH H. J. Lu
2005-01-04 23:36 ` PATCH: Minor readelf update H. J. Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).