From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-37035-listarch-binutils=sources.redhat.com@sources.redhat.com>
Received: (qmail 28330 invoked by alias); 4 Jan 2005 23:36:49 -0000
Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/binutils/>
List-Post: <mailto:binutils@sources.redhat.com>
List-Help: <mailto:binutils-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: binutils-owner@sources.redhat.com
Received: (qmail 28198 invoked from network); 4 Jan 2005 23:36:38 -0000
Received: from unknown (HELO rwcrmhc11.comcast.net) (204.127.198.35)
  by sourceware.org with SMTP; 4 Jan 2005 23:36:38 -0000
Received: from lucon.org ([24.6.212.230]) by comcast.net (rwcrmhc11) with ESMTP
          id <2005010423363801300cb2nce>; Tue, 4 Jan 2005 23:36:38 +0000
Received: by lucon.org (Postfix, from userid 1000)
	id 317DB640F4; Tue,  4 Jan 2005 15:36:38 -0800 (PST)
Date: Tue, 04 Jan 2005 23:36:00 -0000
From: "H. J. Lu" <hjl@lucon.org>
To: binutils@sources.redhat.com
Subject: Re: PATCH: Minor readelf update
Message-ID: <20050104233638.GA558@lucon.org>
References: <20050104223930.GA31989@lucon.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050104223930.GA31989@lucon.org>
User-Agent: Mutt/1.4.1i
X-SW-Source: 2005-01/txt/msg00030.txt.bz2

On Tue, Jan 04, 2005 at 02:39:30PM -0800, H. J. Lu wrote:
> readelf outputs
> 
> Contents of the .debug_str section:
> 
>   0x00000000 5f5f6f66 665f7400 5f494f5f 72656164 __off_t._IO_read
> ...
>   0x00000240 74655f62 61736500 72657375 6c7400   te_base.result.
> Contents of the .debug_loc section:
> 
> This patch adds a newline. I will check it in shortly.
> 

This is the patch I will check in.


H.J.
----
2005-01-04  H.J. Lu  <hongjiu.lu@intel.com>

        * readelf.c (display_debug_loc): Display offsets for hole and
        overlap.
        (display_debug_str): Add a newline at the end.
--- readelf.c.orig	2005-01-04 14:30:34.096675262 -0800
+++ readelf.c	2005-01-04 15:32:39.487003629 -0800
@@ -9483,10 +9483,10 @@ display_debug_loc (Elf_Internal_Shdr *se
 	    {
 	      if (start < next)
 		warn (_("There is a hole [0x%lx - 0x%lx] in .debug_loc section.\n"),
-		      start, next);
+		      start - section_begin, next - section_begin);
 	      else if (start > next)
 		warn (_("There is an overlap [0x%lx - 0x%lx] in .debug_loc section.\n"),
-		      start, next);
+		      start - section_begin, next - section_begin);
 	    }
 	  start = next;
 
@@ -9587,6 +9587,8 @@ display_debug_str (Elf_Internal_Shdr *se
       bytes -= lbytes;
     }
 
+  putchar ('\n');
+
   return 1;
 }