From: Alan Modra <amodra@bigpond.net.au>
To: binutils@sources.redhat.com
Cc: Olaf Hering <olh@suse.de>
Subject: powerpc64 multi-toc linker bug
Date: Thu, 06 Jan 2005 08:40:00 -0000 [thread overview]
Message-ID: <20050106083950.GK11457@bubble.modra.org> (raw)
This fixes a bug in ppc64_elf_size_stubs. The bug could result in an r2
adjusting stub being omitted when it was in fact needed. Which might be
the cause of a gcc bootstrap miscompilation some people are seeing.
* elf64-ppc.c (ppc64_elf_size_stubs): When determining need for
toc adjusting stub, do not test source section flags.
Index: bfd/elf64-ppc.c
===================================================================
RCS file: /cvs/src/src/bfd/elf64-ppc.c,v
retrieving revision 1.182
diff -u -p -r1.182 elf64-ppc.c
--- bfd/elf64-ppc.c 19 Dec 2004 23:24:46 -0000 1.182
+++ bfd/elf64-ppc.c 6 Jan 2005 08:38:44 -0000
@@ -8643,8 +8643,7 @@ ppc64_elf_size_stubs (bfd *output_bfd,
&& code_sec->output_section != NULL
&& (htab->stub_group[code_sec->id].toc_off
!= htab->stub_group[section->id].toc_off)
- && code_sec->has_gp_reloc
- && section->has_gp_reloc)
+ && code_sec->has_gp_reloc)
stub_type = ppc_stub_long_branch_r2off;
}
--
Alan Modra
IBM OzLabs - Linux Technology Centre
reply other threads:[~2005-01-06 8:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050106083950.GK11457@bubble.modra.org \
--to=amodra@bigpond.net.au \
--cc=binutils@sources.redhat.com \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).