From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21769 invoked by alias); 1 Feb 2005 02:44:39 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 21669 invoked from network); 1 Feb 2005 02:44:20 -0000 Received: from unknown (HELO gizmo08ps.bigpond.com) (144.140.71.18) by sourceware.org with SMTP; 1 Feb 2005 02:44:20 -0000 Received: (qmail 6534 invoked from network); 1 Feb 2005 02:44:18 -0000 Received: from unknown (HELO psmam12.bigpond.com) (144.135.25.103) by gizmo08ps.bigpond.com with SMTP; 1 Feb 2005 02:44:18 -0000 Received: from cpe-144-136-221-26.sa.bigpond.net.au ([144.136.221.26]) by psmam12.bigpond.com(MAM REL_3_4_2a 234/54720558) with SMTP id 54720558; Tue, 01 Feb 2005 12:44:18 +1000 Received: by bubble.modra.org (Postfix, from userid 500) id 00DB2176D75; Tue, 1 Feb 2005 13:14:13 +1030 Date: Tue, 01 Feb 2005 02:44:00 -0000 From: Alan Modra To: Andreas Schwab Cc: Ben Elliston , binutils@sources.redhat.com Subject: Re: Last of the gas cleanups Message-ID: <20050201024413.GM11595@bubble.modra.org> Mail-Followup-To: Andreas Schwab , Ben Elliston , binutils@sources.redhat.com References: <20050131234205.GA4941@namadgi> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4i X-SW-Source: 2005-02/txt/msg00006.txt.bz2 On Tue, Feb 01, 2005 at 01:22:21AM +0100, Andreas Schwab wrote: > "Ben Elliston" writes: > > > Index: config/tc-alpha.c > > =================================================================== > > RCS file: /home/bje/src-cvs/src/gas/config/tc-alpha.c,v > > retrieving revision 1.63 > > diff -u -p -u -r1.63 tc-alpha.c > > --- config/tc-alpha.c 31 Jan 2005 23:18:25 -0000 1.63 > > +++ config/tc-alpha.c 31 Jan 2005 23:39:58 -0000 > > @@ -159,30 +159,17 @@ struct alpha_macro > > /* XXX: The non-shift version appears to trigger a compiler bug when > > cross-assembling from x86 w/ gcc 2.7.2. */ > > > > -#if 1 > > #define range_signed_16(x) \ > > (((offsetT) (x) >> 15) == 0 || ((offsetT) (x) >> 15) == -1) > > #define range_signed_32(x) \ > > (((offsetT) (x) >> 31) == 0 || ((offsetT) (x) >> 31) == -1) > > -#else > > -#define range_signed_16(x) ((offsetT) (x) >= -(offsetT) 0x8000 && \ > > - (offsetT) (x) <= (offsetT) 0x7FFF) > > -#define range_signed_32(x) ((offsetT) (x) >= -(offsetT) 0x80000000 && \ > > - (offsetT) (x) <= (offsetT) 0x7FFFFFFF) > > -#endif > > > > /* Macros for sign extending from 16- and 32-bits. */ > > /* XXX: The cast macros will work on all the systems that I care about, > > but really a predicate should be found to use the non-cast forms. */ > > > > -#if 1 > > #define sign_extend_16(x) ((short) (x)) > > #define sign_extend_32(x) ((int) (x)) > > -#else > > -#define sign_extend_16(x) ((offsetT) (((x) & 0xFFFF) ^ 0x8000) - 0x8000) > > -#define sign_extend_32(x) ((offsetT) (((x) & 0xFFFFFFFF) \ > > - ^ 0x80000000) - 0x80000000) > > -#endif > > These should probably go the other way round. The disabled alternatives > are more portable in the long run. Agreed, except that the cast to offsetT should be applied to (x) in sign_extend_*. > --- config/tc-ia64.c 31 Jan 2005 23:18:29 -0000 1.128 > +++ config/tc-ia64.c 31 Jan 2005 23:39:58 -0000 > @@ -11198,16 +11198,11 @@ ia64_handle_align (fragp) > if (!bytes && fragp->tc_frag_data) > { > if (fragp->fr_fix < 16) > -#if 1 > /* FIXME: It won't work with > .align 16 > alloc r32=3Dar.pfs,1,2,4,0 > */ > ; > -#else > - as_bad_where (fragp->fr_file, fragp->fr_line, > - _("Can't add stop bit to mark end of instruction group")); > -#endif > else > /* Bundles are always in little-endian byte order. Make sure > the previous bundle has the stop bit. */ And this patch loses the "It" the comment is referring to. -- Alan Modra IBM OzLabs - Linux Technology Centre