Re: IA64 linker is totally broken (Re: PATCH: ELF linker is broken)

[Alan Modra <amodra@bigpond.net.au>]

This one too.

Index: bfd/ChangeLog
===================================================================
RCS file: /cvs/src/src/bfd/ChangeLog,v
retrieving revision 1.2879
diff -u -p -r1.2879 ChangeLog
--- bfd/ChangeLog	2 Feb 2005 01:16:30 -0000	1.2879
+++ bfd/ChangeLog	2 Feb 2005 01:36:37 -0000
@@ -2,6 +2,7 @@
 
 	* elfxx-ia64.c (elfNN_ia64_new_elf_hash_entry): Don't clear
 	everything, just the field specific to ia64.
+	* elf64-hppa.c (elf64_hppa_new_dyn_hash_entry): Likewise.
 
 2005-02-01  Alan Modra  <amodra@bigpond.net.au>
 
Index: bfd/elf64-hppa.c
===================================================================
RCS file: /cvs/src/src/bfd/elf64-hppa.c,v
retrieving revision 1.52
diff -u -p -r1.52 elf64-hppa.c
--- bfd/elf64-hppa.c	10 Oct 2004 13:58:05 -0000	1.52
+++ bfd/elf64-hppa.c	2 Feb 2005 01:36:39 -0000
@@ -1,5 +1,5 @@
 /* Support for HPPA 64-bit ELF
-   Copyright 1999, 2000, 2001, 2002, 2003, 2004
+   Copyright 1999, 2000, 2001, 2002, 2003, 2004, 2005
    Free Software Foundation, Inc.
 
    This file is part of BFD, the Binary File Descriptor library.
@@ -305,14 +305,15 @@ elf64_hppa_new_dyn_hash_entry (entry, ta
   if (!ret)
     return 0;
 
-  /* Initialize our local data.  All zeros, and definitely easier
-     than setting 8 bit fields.  */
-  memset (ret, 0, sizeof (*ret));
-
   /* Call the allocation method of the superclass.  */
   ret = ((struct elf64_hppa_dyn_hash_entry *)
 	 bfd_hash_newfunc ((struct bfd_hash_entry *) ret, table, string));
 
+  /* Initialize our local data.  All zeros.  */
+  memset (&ret->dlt_offset, 0,
+	  (sizeof (struct elf64_hppa_dyn_hash_entry)
+	   - offsetof (struct elf64_hppa_dyn_hash_entry, dlt_offset)));
+
   return &ret->root;
 }
 

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre