From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32689 invoked by alias); 2 Feb 2005 01:37:50 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 32634 invoked from network); 2 Feb 2005 01:37:44 -0000 Received: from unknown (HELO gizmo01bw.bigpond.com) (144.140.70.11) by sourceware.org with SMTP; 2 Feb 2005 01:37:44 -0000 Received: (qmail 24010 invoked from network); 2 Feb 2005 01:37:42 -0000 Received: from unknown (HELO bwmam12.bigpond.com) (144.135.24.103) by gizmo01bw.bigpond.com with SMTP; 2 Feb 2005 01:37:42 -0000 Received: from cpe-144-136-221-26.sa.bigpond.net.au ([144.136.221.26]) by bwmam12.bigpond.com(MAM REL_3_4_2a 189/60015481) with SMTP id 60015481; Wed, 02 Feb 2005 11:37:42 +1000 Received: by bubble.modra.org (Postfix, from userid 500) id 3B1FBE4356; Wed, 2 Feb 2005 12:07:42 +1030 Date: Wed, 02 Feb 2005 01:37:00 -0000 From: Alan Modra To: binutils@sources.redhat.com Subject: Re: IA64 linker is totally broken (Re: PATCH: ELF linker is broken) Message-ID: <20050202013742.GW11595@bubble.modra.org> Mail-Followup-To: binutils@sources.redhat.com References: <20050131212203.GA27701@lucon.org> <20050131220214.GA28324@lucon.org> <20050201000825.GK11595@bubble.modra.org> <20050201055618.GA5203@lucon.org> <20050201061826.GA5603@lucon.org> <20050201071606.GQ11595@bubble.modra.org> <20050201224550.GA19843@lucon.org> <20050201235701.GT11595@bubble.modra.org> <20050202003925.GA21566@lucon.org> <20050202011206.GV11595@bubble.modra.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050202011206.GV11595@bubble.modra.org> User-Agent: Mutt/1.4i X-SW-Source: 2005-02/txt/msg00044.txt.bz2 This one too. Index: bfd/ChangeLog =================================================================== RCS file: /cvs/src/src/bfd/ChangeLog,v retrieving revision 1.2879 diff -u -p -r1.2879 ChangeLog --- bfd/ChangeLog 2 Feb 2005 01:16:30 -0000 1.2879 +++ bfd/ChangeLog 2 Feb 2005 01:36:37 -0000 @@ -2,6 +2,7 @@ * elfxx-ia64.c (elfNN_ia64_new_elf_hash_entry): Don't clear everything, just the field specific to ia64. + * elf64-hppa.c (elf64_hppa_new_dyn_hash_entry): Likewise. 2005-02-01 Alan Modra Index: bfd/elf64-hppa.c =================================================================== RCS file: /cvs/src/src/bfd/elf64-hppa.c,v retrieving revision 1.52 diff -u -p -r1.52 elf64-hppa.c --- bfd/elf64-hppa.c 10 Oct 2004 13:58:05 -0000 1.52 +++ bfd/elf64-hppa.c 2 Feb 2005 01:36:39 -0000 @@ -1,5 +1,5 @@ /* Support for HPPA 64-bit ELF - Copyright 1999, 2000, 2001, 2002, 2003, 2004 + Copyright 1999, 2000, 2001, 2002, 2003, 2004, 2005 Free Software Foundation, Inc. This file is part of BFD, the Binary File Descriptor library. @@ -305,14 +305,15 @@ elf64_hppa_new_dyn_hash_entry (entry, ta if (!ret) return 0; - /* Initialize our local data. All zeros, and definitely easier - than setting 8 bit fields. */ - memset (ret, 0, sizeof (*ret)); - /* Call the allocation method of the superclass. */ ret = ((struct elf64_hppa_dyn_hash_entry *) bfd_hash_newfunc ((struct bfd_hash_entry *) ret, table, string)); + /* Initialize our local data. All zeros. */ + memset (&ret->dlt_offset, 0, + (sizeof (struct elf64_hppa_dyn_hash_entry) + - offsetof (struct elf64_hppa_dyn_hash_entry, dlt_offset))); + return &ret->root; } -- Alan Modra IBM OzLabs - Linux Technology Centre