public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@bigpond.net.au>
To: "H. J. Lu" <hjl@gcc.gnu.org>
Cc: binutils@sources.redhat.com
Subject: Re: PATCH: SHN_XINDEX support is broken
Date: Mon, 07 Feb 2005 16:01:00 -0000	[thread overview]
Message-ID: <20050206220740.GC23954@bubble.modra.org> (raw)
In-Reply-To: <20050206181859.GA28251@lucon.org>

On Sun, Feb 06, 2005 at 10:18:59AM -0800, H. J. Lu wrote:
> I have been looking at the change. I am not 100% sure if it will be
> always correct. Will the symbol table be read in by SHT_REL/SHT_RELA?

Yes.  elf.c:1940
	/* Get the symbol table.  */
	if ((elf_elfsections (abfd)[hdr->sh_link]->sh_type == SHT_SYMTAB
	     || elf_elfsections (abfd)[hdr->sh_link]->sh_type == SHT_DYNSYM)
	    && ! bfd_section_from_shdr (abfd, hdr->sh_link))
	  return FALSE;

> What if a file doesn't have them and does have SHT_GROUP?

group_signature loads the symbol table.

elf.c:450
  /* First we need to ensure the symbol table is available.  */
  if (! bfd_section_from_shdr (abfd, ghdr->sh_link))
    return NULL;

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

  reply	other threads:[~2005-02-06 23:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-06  7:14 H. J. Lu
2005-02-06  7:24 ` PATCH: " H. J. Lu
2005-02-06 10:04   ` H. J. Lu
2005-02-06 15:03   ` Alan Modra
2005-02-07  2:30     ` H. J. Lu
2005-02-07  3:41     ` H. J. Lu
2005-02-07 16:01       ` Alan Modra [this message]
2005-02-06 10:02 ` H. J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050206220740.GC23954@bubble.modra.org \
    --to=amodra@bigpond.net.au \
    --cc=binutils@sources.redhat.com \
    --cc=hjl@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).