From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11808 invoked by alias); 9 Feb 2005 00:06:13 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 11709 invoked from network); 9 Feb 2005 00:06:06 -0000 Received: from unknown (HELO iris1.csv.ica.uni-stuttgart.de) (129.69.118.2) by sourceware.org with SMTP; 9 Feb 2005 00:06:06 -0000 Received: from rembrandt.csv.ica.uni-stuttgart.de ([129.69.118.42]) by iris1.csv.ica.uni-stuttgart.de with esmtp id 1CyfMm-00063o-00; Wed, 09 Feb 2005 01:06:00 +0100 Received: from ica2_ts by rembrandt.csv.ica.uni-stuttgart.de with local (Exim 3.35 #1 (Debian)) id 1CyfMl-00030w-00; Wed, 09 Feb 2005 01:05:59 +0100 Date: Wed, 09 Feb 2005 09:21:00 -0000 To: "Maciej W. Rozycki" Cc: binutils@sources.redhat.com Subject: Re: [PATCH] MIPS/ELF: Fixes for external R_MIPS16_GPREL relocations Message-ID: <20050209000559.GC6840@rembrandt.csv.ica.uni-stuttgart.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6+20040907i From: Thiemo Seufer X-SW-Source: 2005-02/txt/msg00144.txt.bz2 Maciej W. Rozycki wrote: > Hello, > > While peeking at code to handle GPREL relocations I've discovered another > discrepancy, with R_MIPS16_GPREL ones this time. Unlike the others, the > (n)64 code treats such relocations against external symbols as if they > were against local ones. > > Here is a fix -- tested for the mips64-linux-gnu, mipsel-linux-gnu and > mips64el-elf targets with no regressions. > > 2005-02-03 Maciej W. Rozycki > > * elf64-mips.c (mips16_gprel_reloc): Update a comment. > * elfn32-mips.c (mips16_gprel_reloc): Keep R_MIPS16_GPREL > relocations against external symbols unchanged. > > OK to apply? Ok. Thiemo