From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12267 invoked by alias); 9 Feb 2005 19:02:28 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 12202 invoked from network); 9 Feb 2005 19:02:19 -0000 Received: from unknown (HELO sunsite.mff.cuni.cz) (195.113.15.26) by sourceware.org with SMTP; 9 Feb 2005 19:02:19 -0000 Received: from sunsite.mff.cuni.cz (sunsite.mff.cuni.cz [127.0.0.1]) by sunsite.mff.cuni.cz (8.13.1/8.13.1) with ESMTP id j19J2JIA020438 for ; Wed, 9 Feb 2005 20:02:19 +0100 Received: (from jj@localhost) by sunsite.mff.cuni.cz (8.13.1/8.13.1/Submit) id j19J2I01020433 for binutils@sources.redhat.com; Wed, 9 Feb 2005 20:02:18 +0100 Date: Wed, 09 Feb 2005 22:18:00 -0000 From: Jakub Jelinek To: binutils@sources.redhat.com Subject: [PATCH] Fix ppc64 .note.GNU-stack handling Message-ID: <20050209190218.GF4777@sunsite.mff.cuni.cz> Reply-To: Jakub Jelinek Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i X-SW-Source: 2005-02/txt/msg00178.txt.bz2 Hi! .note.GNU-stack section handling is broken on ppc64 (and probably on hppa as well). If there are any .note.GNU-stack sections in the input, then all of them must have that section and without SEC_CODE, otherwise the result is executable. But on ppc64 there is a linker stubs magic bfd synthetized by the linker that never has this section, so if there are any .note.GNU-stack sections, whether executable or not, the result is PT_GNU_STACK RWE. Fixed thusly, ok to commit? 2005-02-09 Jakub Jelinek * bfd-in.h (BFD_LINKER_CREATED): Define. * bfd-in2.h: Rebuilt. * elflink.c (bfd_elf_size_dynamic_sections): Disregard BFD_LINKER_CREATED bfds when determining input bfds without .note.GNU-stack section. * emultempl/hppaelf.em (hppaelf_create_output_section_statements): Set BFD_LINKER_CREATED on the stubs bfd. * emultempl/ppc64elf.em (ppc_create_output_section_statements): Likewise. --- bfd/bfd-in.h.jj 2005-02-09 16:06:50.000000000 +0100 +++ bfd/bfd-in.h 2005-02-09 17:44:34.000000000 +0100 @@ -1,7 +1,7 @@ /* Main header file for the bfd library -- portable access to object files. Copyright 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, - 1999, 2000, 2001, 2002, 2003, 2004 Free Software Foundation, Inc. + 1999, 2000, 2001, 2002, 2003, 2004, 2005 Free Software Foundation, Inc. Contributed by Cygnus Support. @@ -230,6 +230,10 @@ bfd_format; /* The sections in this BFD specify a memory page. */ #define HAS_LOAD_PAGE 0x1000 + +/* This BFD has been created by the linker and doesn't correspond + to any input file. */ +#define BFD_LINKER_CREATED 0x2000 /* Symbols and relocation. */ --- bfd/bfd-in2.h.jj 2005-02-09 16:06:50.000000000 +0100 +++ bfd/bfd-in2.h 2005-02-09 17:45:09.698719811 +0100 @@ -8,7 +8,7 @@ /* Main header file for the bfd library -- portable access to object files. Copyright 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, - 1999, 2000, 2001, 2002, 2003, 2004 Free Software Foundation, Inc. + 1999, 2000, 2001, 2002, 2003, 2004, 2005 Free Software Foundation, Inc. Contributed by Cygnus Support. @@ -245,6 +245,10 @@ bfd_format; /* The sections in this BFD specify a memory page. */ #define HAS_LOAD_PAGE 0x1000 + +/* This BFD has been created by the linker and doesn't correspond + to any input file. */ +#define BFD_LINKER_CREATED 0x2000 /* Symbols and relocation. */ --- bfd/elflink.c.jj 2005-02-09 16:06:57.000000000 +0100 +++ bfd/elflink.c 2005-02-09 17:47:45.209950411 +0100 @@ -4895,7 +4895,7 @@ bfd_elf_size_dynamic_sections (bfd *outp { asection *s; - if (inputobj->flags & DYNAMIC) + if (inputobj->flags & (DYNAMIC | BFD_LINKER_CREATED)) continue; s = bfd_get_section_by_name (inputobj, ".note.GNU-stack"); if (s) --- ld/emultempl/hppaelf.em.jj 2005-01-21 13:01:18.000000000 +0100 +++ ld/emultempl/hppaelf.em 2005-02-09 17:46:46.442444375 +0100 @@ -88,6 +88,7 @@ hppaelf_create_output_section_statements return; } + stub_file->the_bfd->flags |= BFD_LINKER_CREATED; ldlang_add_file (stub_file); } --- ld/emultempl/ppc64elf.em.jj 2005-01-20 09:50:47.000000000 +0100 +++ ld/emultempl/ppc64elf.em 2005-02-09 17:47:11.103040786 +0100 @@ -92,6 +92,7 @@ ppc_create_output_section_statements (vo return; } + stub_file->the_bfd->flags |= BFD_LINKER_CREATED; ldlang_add_file (stub_file); ppc64_elf_init_stub_bfd (stub_file->the_bfd, &link_info); } Jakub