public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Olaf Hering <olh@suse.de>
To: binutils@sources.redhat.com
Subject: Re: ld: can not edit toc Invalid operation
Date: Sun, 13 Feb 2005 18:52:00 -0000	[thread overview]
Message-ID: <20050213124446.GA26117@suse.de> (raw)
In-Reply-To: <20050213123550.GH22790@bubble.modra.org>

 On Sun, Feb 13, Alan Modra wrote:

> On Sun, Feb 13, 2005 at 09:58:21AM +0100, Olaf Hering wrote:
> >  On Sun, Feb 13, Alan Modra wrote:
> > > > /home/abuild/binhead/bin/ld: can not edit toc Invalid operation
> > > 
> > > This is the real error.  The segfault is a consequence of
> > > ppc64elf.em:ppc_before_allocation not calling the elf32.em
> > > before_allocation function.  I guess I should make this a fatal
> > > error..
> > > 
> > > Can you find out why ppc64_elf_edit_toc is returning FALSE?
> > 
> > _bfd_elf_link_read_relocs() returns NULL, line 7018
> 
> Silly me.  It's quite possible to have a toc section that has no
> relocs.
> 
> 	* elf64-ppc.c (ppc64_elf_edit_toc): Skip toc if size is zero.
> 	Skip toc reloc adjust if reloc_count is zero.
> 
> This tidies up the error situation.  I chose to leave most of the errors
> non-fatal, which means we need to continue on with normal processing in
> these functions rather than just returning.
> 
> 	* emultempl/ppc64elf.em (ppc_create_output_section_statements): Make
> 	an error creating fake bfd fatal.
> 	(ppc_before_allocation): Continue on after errors.
> 	(gld${EMULATION_NAME}_finish): Likewise.

That patch fixed it, thanks.

      reply	other threads:[~2005-02-13 12:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20050212225221.GA11623@suse.de>
     [not found] ` <20050213072708.GG22790@bubble.modra.org>
     [not found]   ` <20050213085821.GB21230@suse.de>
2005-02-13 18:42     ` Alan Modra
2005-02-13 18:52       ` Olaf Hering [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050213124446.GA26117@suse.de \
    --to=olh@suse.de \
    --cc=binutils@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).