From: Alan Modra <amodra@bigpond.net.au>
To: binutils@sources.redhat.com
Subject: some more warning fixes
Date: Wed, 16 Feb 2005 09:51:00 -0000 [thread overview]
Message-ID: <20050216023727.GK10128@bubble.modra.org> (raw)
* coff-arm.c (coff_arm_is_local_label_name): Warning fix.
* elf32-frv.c (frvfdpic_relocs_info_hash): Likewise.
* pef.c (bfd_pef_scan): Don't ignore return value of
bfd_pef_scan_start_address.
Index: bfd/coff-arm.c
===================================================================
RCS file: /cvs/src/src/bfd/coff-arm.c,v
retrieving revision 1.56
diff -u -p -r1.56 coff-arm.c
--- bfd/coff-arm.c 31 Jan 2005 23:13:15 -0000 1.56
+++ bfd/coff-arm.c 16 Feb 2005 02:25:12 -0000
@@ -2504,7 +2504,9 @@ coff_arm_is_local_label_name (abfd, name
#ifdef USER_LABEL_PREFIX
if (USER_LABEL_PREFIX[0] != 0)
{
- if (strncmp (name, USER_LABEL_PREFIX, strlen (USER_LABEL_PREFIX)) == 0)
+ size_t len = strlen (USER_LABEL_PREFIX);
+
+ if (strncmp (name, USER_LABEL_PREFIX, len) == 0)
return FALSE;
}
#endif
Index: bfd/elf32-frv.c
===================================================================
RCS file: /cvs/src/src/bfd/elf32-frv.c,v
retrieving revision 1.35
diff -u -p -r1.35 elf32-frv.c
--- bfd/elf32-frv.c 7 Feb 2005 07:59:34 -0000 1.35
+++ bfd/elf32-frv.c 16 Feb 2005 02:25:17 -0000
@@ -1144,8 +1144,8 @@ frvfdpic_relocs_info_hash (const void *e
const struct frvfdpic_relocs_info *entry = entry_;
return (entry->symndx == -1
- ? (long)entry->d.h->root.root.hash
- : entry->symndx + entry->d.abfd->id * 257) + entry->addend;
+ ? (long) entry->d.h->root.root.hash
+ : entry->symndx + (long) entry->d.abfd->id * 257) + entry->addend;
}
/* Test whether the key fields of two frvfdpic_relocs_info entries are
Index: bfd/pef.c
===================================================================
RCS file: /cvs/src/src/bfd/pef.c,v
retrieving revision 1.11
diff -u -p -r1.11 pef.c
--- bfd/pef.c 31 Jan 2005 23:13:29 -0000 1.11
+++ bfd/pef.c 16 Feb 2005 02:25:18 -0000
@@ -600,7 +600,7 @@ bfd_pef_scan (abfd, header, mdata)
}
if (bfd_pef_scan_start_address (abfd) < 0)
- ;
+ return -1;
abfd->tdata.pef_data = mdata;
--
Alan Modra
IBM OzLabs - Linux Technology Centre
next reply other threads:[~2005-02-16 2:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-16 9:51 Alan Modra [this message]
2005-02-16 11:55 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050216023727.GK10128@bubble.modra.org \
--to=amodra@bigpond.net.au \
--cc=binutils@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).