From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27922 invoked by alias); 16 Feb 2005 12:28:47 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 27887 invoked from network); 16 Feb 2005 12:28:40 -0000 Received: from unknown (HELO gizmo02ps.bigpond.com) (144.140.71.12) by sourceware.org with SMTP; 16 Feb 2005 12:28:40 -0000 Received: (qmail 28631 invoked from network); 16 Feb 2005 12:28:38 -0000 Received: from unknown (HELO psmam12.bigpond.com) (144.135.25.103) by gizmo02ps.bigpond.com with SMTP; 16 Feb 2005 12:28:38 -0000 Received: from cpe-144-136-221-26.sa.bigpond.net.au ([144.136.221.26]) by psmam12.bigpond.com(MAM REL_3_4_2a 234/8625882) with SMTP id 8625882; Wed, 16 Feb 2005 22:28:38 +1000 Received: by bubble.modra.org (Postfix, from userid 500) id EA8E7189E28; Wed, 16 Feb 2005 22:58:37 +1030 Date: Wed, 16 Feb 2005 18:48:00 -0000 From: Alan Modra To: Nick Clifton Cc: binutils@sources.redhat.com Subject: Re: Making generic ld testcases pass on more targets Message-ID: <20050216122837.GS10128@bubble.modra.org> Mail-Followup-To: Nick Clifton , binutils@sources.redhat.com References: <20050216115635.GR10128@bubble.modra.org> <42133911.2010905@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42133911.2010905@redhat.com> User-Agent: Mutt/1.4i X-SW-Source: 2005-02/txt/msg00370.txt.bz2 On Wed, Feb 16, 2005 at 12:14:09PM +0000, Nick Clifton wrote: > >+#ifdef BFD_ASSEMBLER > >+ {"dc.a", cons, 0}, > >+#endif > > I like this, but why make the pseudo specific to BFD_ASSEMBLERs ? Because only BFD_ASSEMBLER has arch_info. > >+ nbytes = (stdoutput->arch_info->bits_per_address - 1) / 8; > > It might make sense to allow for individual targets to override this > computation with their own value if they so wish. Yes, that would allow non-BFD_ASSEMBLER to use dc.a too. Another approach occurred to me also, a variation on using __address_size. Instead of the assembler providing the symbol, we could have the test harness feed a suitable --defsym to the assembler, chosen by target name. -- Alan Modra IBM OzLabs - Linux Technology Centre