From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28809 invoked by alias); 16 Feb 2005 19:22:00 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 28778 invoked from network); 16 Feb 2005 19:21:55 -0000 Received: from unknown (HELO iris1.csv.ica.uni-stuttgart.de) (129.69.118.2) by sourceware.org with SMTP; 16 Feb 2005 19:21:55 -0000 Received: from rembrandt.csv.ica.uni-stuttgart.de ([129.69.118.42]) by iris1.csv.ica.uni-stuttgart.de with esmtp id 1D1UkE-0004Td-00; Wed, 16 Feb 2005 20:21:54 +0100 Received: from ica2_ts by rembrandt.csv.ica.uni-stuttgart.de with local (Exim 3.35 #1 (Debian)) id 1D1UkD-0007Hm-00; Wed, 16 Feb 2005 20:21:53 +0100 Date: Thu, 17 Feb 2005 01:34:00 -0000 To: "Maciej W. Rozycki" Cc: binutils@sources.redhat.com Subject: Re: [PATCH] MIPS gas: Fix macro expansions for .set noat Message-ID: <20050216192153.GH1757@rembrandt.csv.ica.uni-stuttgart.de> References: <20050216154924.GG1757@rembrandt.csv.ica.uni-stuttgart.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6+20040907i From: Thiemo Seufer X-SW-Source: 2005-02/txt/msg00379.txt.bz2 Maciej W. Rozycki wrote: > Thiemo, > > More comments about that change -- as I understand our policy wrt $at > being used with ".set noat" in effect is to go for it regardless and only > issue a warning (that can be converted to an error with --fatal-warnings). > Therefore we shouldn't use as_bad() in this case. IMHO it should be an error if the result can't work at all. I don't see a case where overwriting the base register before its use could be the programmers intention. > Moreover, the situation > is actually already handled in general -- see the bottom exit point from > macro() -- so we should really only track down the failing execution path > within that function and check whether its epilogue correctly executes a > functional equivalent of this code: > > if (used_at) > break; > else > return; This causes "used $at in .set noat" warnings. That's a rather confusing message, given that no use of $at was specified in the source. Thiemo