From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9921 invoked by alias); 18 Feb 2005 00:13:15 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 9521 invoked from network); 18 Feb 2005 00:12:40 -0000 Received: from unknown (HELO gizmo03ps.bigpond.com) (144.140.71.13) by sourceware.org with SMTP; 18 Feb 2005 00:12:40 -0000 Received: (qmail 15946 invoked from network); 18 Feb 2005 00:12:38 -0000 Received: from unknown (HELO psmam12.bigpond.com) (144.135.25.103) by gizmo03ps.bigpond.com with SMTP; 18 Feb 2005 00:12:38 -0000 Received: from cpe-144-136-221-26.sa.bigpond.net.au ([144.136.221.26]) by psmam12.bigpond.com(MAM REL_3_4_2a 234/1071072) with SMTP id 1071072; Fri, 18 Feb 2005 10:12:38 +1000 Received: by bubble.modra.org (Postfix, from userid 500) id 8569618FB69; Fri, 18 Feb 2005 10:42:38 +1030 Date: Fri, 18 Feb 2005 02:18:00 -0000 From: Alan Modra To: binutils@sources.redhat.com Subject: Re: mips warning Message-ID: <20050218001238.GF10128@bubble.modra.org> Mail-Followup-To: binutils@sources.redhat.com References: <20050218000111.GD10128@bubble.modra.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050218000111.GD10128@bubble.modra.org> User-Agent: Mutt/1.4i X-SW-Source: 2005-02/txt/msg00420.txt.bz2 On Fri, Feb 18, 2005 at 10:31:11AM +1030, Alan Modra wrote: > gas/config/tc-mips.c:4171: warning: 'tempreg' may be used uninitialized in this function > * config/tc-mips.c (macro ): Always set tempreg. Ug. The same is needed for st. * config/tc-mips.c (macro ): Always set tempreg. Index: gas/config/tc-mips.c =================================================================== RCS file: /cvs/src/src/gas/config/tc-mips.c,v retrieving revision 1.283 diff -u -p -r1.283 tc-mips.c --- gas/config/tc-mips.c 17 Feb 2005 13:46:04 -0000 1.283 +++ gas/config/tc-mips.c 18 Feb 2005 00:11:58 -0000 @@ -5765,15 +5765,14 @@ macro (struct mips_cl_insn *ip) tempreg = AT; used_at = 1; } - else if (breg == treg - && (offset_expr.X_op != O_constant - || (offset_expr.X_add_number > 0x7fff - || offset_expr.X_add_number < -0x8000))) - { - as_bad(_("load expansion needs $at register")); - } else { + if (breg == treg + && (offset_expr.X_op != O_constant + || (offset_expr.X_add_number > 0x7fff + || offset_expr.X_add_number < -0x8000))) + as_bad(_("load expansion needs $at register")); + tempreg = treg; used_at = 0; } @@ -5850,15 +5849,14 @@ macro (struct mips_cl_insn *ip) tempreg = AT; used_at = 1; } - else if (breg == treg - && (offset_expr.X_op != O_constant - || (offset_expr.X_add_number > 0x7fff - || offset_expr.X_add_number < -0x8000))) - { - as_bad(_("store expansion needs $at register")); - } else { + if (breg == treg + && (offset_expr.X_op != O_constant + || (offset_expr.X_add_number > 0x7fff + || offset_expr.X_add_number < -0x8000))) + as_bad(_("store expansion needs $at register")); + tempreg = treg; used_at = 0; } -- Alan Modra IBM OzLabs - Linux Technology Centre