* PATCH: Modify .debug_loc output from readelf
@ 2005-02-18 13:47 H. J. Lu
2005-02-18 19:52 ` Nick Clifton
2005-02-26 11:48 ` H. J. Lu
0 siblings, 2 replies; 3+ messages in thread
From: H. J. Lu @ 2005-02-18 13:47 UTC (permalink / raw)
To: binutils
We output:
Contents of the .debug_loc section:
Offset Begin End Expression
<End of list>
00000014 00000000 00000004 (DW_OP_fbreg: 4)
00000014 00000004 00000028 (DW_OP_reg2)
<End of list>
00000033 0000002a 0000002a (DW_OP_breg4: -1) (start == end)
<End of list>
This patch changes it to
Offset Begin End Expression
00000000 <End of list>
00000014 00000000 00000004 (DW_OP_fbreg: 4)
00000014 00000004 00000028 (DW_OP_reg2)
00000014 <End of list>
00000033 0000002a 0000002a (DW_OP_breg4: -1) (start == end)
00000033 <End of list>
It is clearer.
H.J.
----
2005-02-17 H.J. Lu <hongjiu.lu@intel.com>
* readelf.c (display_debug_loc): Print out offset for end of
list.
--- binutils/readelf.c.hole 2005-02-11 09:19:41.000000000 -0800
+++ binutils/readelf.c 2005-02-17 18:52:13.283086220 -0800
@@ -9490,7 +9490,10 @@ display_debug_loc (Elf_Internal_Shdr *se
start += pointer_size;
if (begin == 0 && end == 0)
- break;
+ {
+ printf (_(" %8.8lx <End of list>\n"), offset);
+ break;
+ }
/* Check base address specifiers. */
if (begin == -1UL && end != -1UL)
@@ -9524,8 +9527,6 @@ display_debug_loc (Elf_Internal_Shdr *se
start += length;
}
-
- fputs (_(" <End of list>\n"), stdout);
}
}
return 1;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: PATCH: Modify .debug_loc output from readelf
2005-02-18 13:47 PATCH: Modify .debug_loc output from readelf H. J. Lu
@ 2005-02-18 19:52 ` Nick Clifton
2005-02-26 11:48 ` H. J. Lu
1 sibling, 0 replies; 3+ messages in thread
From: Nick Clifton @ 2005-02-18 19:52 UTC (permalink / raw)
To: H. J. Lu; +Cc: binutils
Hi H. J.
> 2005-02-17 H.J. Lu <hongjiu.lu@intel.com>
>
> * readelf.c (display_debug_loc): Print out offset for end of
> list.
Approved - please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: Modify .debug_loc output from readelf
2005-02-18 13:47 PATCH: Modify .debug_loc output from readelf H. J. Lu
2005-02-18 19:52 ` Nick Clifton
@ 2005-02-26 11:48 ` H. J. Lu
1 sibling, 0 replies; 3+ messages in thread
From: H. J. Lu @ 2005-02-26 11:48 UTC (permalink / raw)
To: binutils
On Thu, Feb 17, 2005 at 06:57:56PM -0800, H. J. Lu wrote:
> We output:
>
> Contents of the .debug_loc section:
>
> Offset Begin End Expression
> <End of list>
> 00000014 00000000 00000004 (DW_OP_fbreg: 4)
> 00000014 00000004 00000028 (DW_OP_reg2)
> <End of list>
> 00000033 0000002a 0000002a (DW_OP_breg4: -1) (start == end)
> <End of list>
>
> This patch changes it to
>
> Offset Begin End Expression
> 00000000 <End of list>
> 00000014 00000000 00000004 (DW_OP_fbreg: 4)
> 00000014 00000004 00000028 (DW_OP_reg2)
> 00000014 <End of list>
> 00000033 0000002a 0000002a (DW_OP_breg4: -1) (start == end)
> 00000033 <End of list>
>
> It is clearer.
>
>
> H.J.
> ----
> 2005-02-17 H.J. Lu <hongjiu.lu@intel.com>
>
> * readelf.c (display_debug_loc): Print out offset for end of
> list.
>
display_debug_ranges has the same problem. I will check in this one
as an obvious fix.
H.J.
---
2005-02-25 H.J. Lu <hongjiu.lu@intel.com>
* readelf.c (display_debug_ranges): Print out offset for end of
list.
--- binutils/readelf.c.addr 2005-02-25 12:14:14.304752738 -0800
+++ binutils/readelf.c 2005-02-25 13:32:12.288017680 -0800
@@ -9837,7 +9837,10 @@ display_debug_ranges (Elf_Internal_Shdr
start += pointer_size;
if (begin == 0 && end == 0)
- break;
+ {
+ printf (_(" %8.8lx <End of list>\n"), offset);
+ break;
+ }
/* Check base address specifiers. */
if (begin == -1UL && end != -1UL)
@@ -9858,7 +9861,6 @@ display_debug_ranges (Elf_Internal_Shdr
putchar ('\n');
}
- fputs (_(" <End of list>\n"), stdout);
}
}
putchar ('\n');
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-02-25 22:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-02-18 13:47 PATCH: Modify .debug_loc output from readelf H. J. Lu
2005-02-18 19:52 ` Nick Clifton
2005-02-26 11:48 ` H. J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).