public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: "H. J. Lu" <hjl@lucon.org>
Cc: binutils@sources.redhat.com
Subject: Re: PATCH: Test the just built windres/dlltool only
Date: Mon, 21 Feb 2005 09:59:00 -0000	[thread overview]
Message-ID: <20050218230100.GA28226@nevyn.them.org> (raw)
In-Reply-To: <20050218225935.GA30688@lucon.org>

On Fri, Feb 18, 2005 at 02:59:35PM -0800, H. J. Lu wrote:
> windres/dlltool may not be built for all platforms. But we are picking
> up them from PATH even if they weren't built at all. This patch
> changes it.

If they are on your $PATH, why aren't we building them?  This patch
will disable the tests when testing an installed binutils, I think.

> 
> 
> H.J.
> ----
> 2005-02-18  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	* config/default.exp: Set WINDRES only if windres is built. Set
> 	DLLTOOL only if dlltool is built.
> 
> --- binutils/testsuite/config/default.exp.win	2004-11-05 14:41:25.000000000 -0800
> +++ binutils/testsuite/config/default.exp	2005-02-18 14:30:17.384437504 -0800
> @@ -62,11 +62,11 @@ if ![info exists READELF] then {
>  if ![info exists READELFFLAGS] then {
>      set READELFFLAGS ""
>  }
> -if ![info exists WINDRES] then {
> -    set WINDRES [findfile $base_dir/windres]
> +if {![info exists WINDRES] && [file exists $base_dir/windres]} then {
> +    set WINDRES $base_dir/windres
>  }
> -if ![info exists DLLTOOL] then {
> -    set DLLTOOL [findfile $base_dir/dlltool]
> +if {![info exists DLLTOOL] && [file exists $base_dir/dlltool] } then {
> +    set DLLTOOL $base_dir/dlltool
>  }
>  
>  if ![file isdirectory tmpdir] {catch "exec mkdir tmpdir" status}
> 

-- 
Daniel Jacobowitz
CodeSourcery, LLC

  reply	other threads:[~2005-02-18 23:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-21  8:37 H. J. Lu
2005-02-21  9:59 ` Daniel Jacobowitz [this message]
2005-02-21 10:29   ` H. J. Lu
2005-02-21 20:38     ` Nick Clifton
2005-02-21 21:09       ` H. J. Lu
2005-02-22 19:23         ` Nick Clifton
2005-02-23  2:26           ` H. J. Lu
2005-02-23 16:11             ` Nick Clifton
2005-02-24  5:37               ` H. J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050218230100.GA28226@nevyn.them.org \
    --to=drow@false.org \
    --cc=binutils@sources.redhat.com \
    --cc=hjl@lucon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).