From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9497 invoked by alias); 22 Feb 2005 00:44:41 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 9464 invoked from network); 22 Feb 2005 00:44:36 -0000 Received: from unknown (HELO gizmo11bw.bigpond.com) (144.140.70.21) by sourceware.org with SMTP; 22 Feb 2005 00:44:36 -0000 Received: (qmail 15738 invoked from network); 22 Feb 2005 00:44:35 -0000 Received: from unknown (HELO bwmam12.bigpond.com) (144.135.24.103) by gizmo11bw.bigpond.com with SMTP; 22 Feb 2005 00:44:35 -0000 Received: from cpe-144-136-221-26.sa.bigpond.net.au ([144.136.221.26]) by bwmam12.bigpond.com(MAM REL_3_4_2a 189/10590900) with SMTP id 10590900; Tue, 22 Feb 2005 10:44:35 +1000 Received: by bubble.modra.org (Postfix, from userid 500) id C075B17F976; Tue, 22 Feb 2005 11:14:34 +1030 Date: Tue, 22 Feb 2005 09:23:00 -0000 From: Alan Modra To: binutils@sources.redhat.com Subject: Re: TLS support for MIPS Message-ID: <20050222004434.GD900@bubble.modra.org> Mail-Followup-To: binutils@sources.redhat.com References: <20050207230014.GA32655@nevyn.them.org> <20050208051602.GA19414@bubble.modra.org> <20050221155214.GA19265@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050221155214.GA19265@nevyn.them.org> User-Agent: Mutt/1.4i X-SW-Source: 2005-02/txt/msg00493.txt.bz2 On Mon, Feb 21, 2005 at 10:52:14AM -0500, Daniel Jacobowitz wrote: > On Tue, Feb 08, 2005 at 03:46:02PM +1030, Alan Modra wrote: > > On Mon, Feb 07, 2005 at 06:00:14PM -0500, Daniel Jacobowitz wrote: > > > * elflink.c: Don't exclude sections based on a shared library input. > > > > This would be better in ldlang_add_file, I think. > > Like so? Tested on a bunch of different MIPS configurations, with no > problems. Only thing it might affect is --just-syms with a dynamic > object... well, don't do that then. Yes, don't do that. elflink.c:3268 /* ld --just-symbols and dynamic objects don't mix very well. Test for --just-symbols by looking at info set up by _bfd_elf_link_just_syms. */ if ((s = abfd->sections) != NULL && s->sec_info_type == ELF_INFO_TYPE_JUST_SYMS) goto error_return; But of course doing as I suggested means we don't get sec_info_type set and the error isn't caught. So maybe you'd better do * ldlang.c (section_already_linked): Don't call bfd_section_already_linked for dynamic objects. Patch pre-approved. -- Alan Modra IBM OzLabs - Linux Technology Centre