From: Alan Modra <amodra@bigpond.net.au>
To: "H. J. Lu" <hjl@lucon.org>
Cc: binutils@sources.redhat.com
Subject: Re: PATCH: Fix "FAIL: objcopy (simple copy)" for tic54x-coff
Date: Tue, 22 Feb 2005 09:34:00 -0000 [thread overview]
Message-ID: <20050222005716.GE900@bubble.modra.org> (raw)
In-Reply-To: <20050221210909.GA14151@lucon.org>
> * coffcode.h (coff_write_relocs): Clear the r_reserved field
> if COFF_REL_HAS_R_RESERVED is defined before swapping out
> relocation.
This should really be done by defining a coff_SWAP_reloc_out function
for these targets. I'm not disapproving of the patch since the coff
support is already a mess of macros, but I'm not willing to approve
the patch myself..
--
Alan Modra
IBM OzLabs - Linux Technology Centre
next prev parent reply other threads:[~2005-02-22 0:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-22 0:15 H. J. Lu
2005-02-22 9:34 ` Alan Modra [this message]
2005-02-22 18:45 ` Nick Clifton
2005-02-23 8:03 ` H. J. Lu
2005-02-23 14:20 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050222005716.GE900@bubble.modra.org \
--to=amodra@bigpond.net.au \
--cc=binutils@sources.redhat.com \
--cc=hjl@lucon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).