From: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
To: Eric Christopher <echristo@redhat.com>
Cc: "Maciej W. Rozycki" <macro@mips.com>,
binutils@sources.redhat.com,
"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH] MIPS gas/ld test suite portability fixes
Date: Wed, 23 Feb 2005 00:57:00 -0000 [thread overview]
Message-ID: <20050222225421.GF7729@rembrandt.csv.ica.uni-stuttgart.de> (raw)
In-Reply-To: <1109110466.5032.25.camel@localhost.localdomain>
Eric Christopher wrote:
>
> > I meant something like:
> >
> > --- tc-mips.c 18 Feb 2005 22:12:50 -0000 1.284
> > +++ tc-mips.c 22 Feb 2005 21:54:59 -0000
> > @@ -10652,7 +10694,11 @@ mips_after_parse_args (void)
> > }
> >
> > if (arch_info == 0)
> > - arch_info = mips_parse_cpu ("default CPU", MIPS_CPU_STRING_DEFAULT);
> > + {
> > + arch_info = mips_parse_cpu ("default CPU", MIPS_CPU_STRING_DEFAULT);
> > + if (ABI_NEEDS_64BIT_REGS (mips_abi) && !ISA_HAS_64BIT_REGS (arch_info->isa))
> > + arch_info->isa = ISA_MIPS3;
> > + }
> >
> > if (ABI_NEEDS_64BIT_REGS (mips_abi) && !ISA_HAS_64BIT_REGS (arch_info->isa))
> > as_bad ("-march=%s is not compatible with the selected ABI",
> >
> >
> > (This fails to compile because arch_info is a constant.)
>
> No, I definitely don't like this. It's going back to the era when
> gcc/gas "guessed" what you meant.
It is not a guess in this case, and gcc uses the from-abi hack to
figure it out correctly. Without it, e.g.
gcc -mabi=64
would behave differently depending on its configuration. That's surely
counterintuitive and adds e.g. more breakage potential to Makefile
portability.
> If we're passing an abi and don't have
> a required minimum ISA either passed or by default then we should error
> out.
I agree it makes the ABI/ISA/ARCH/TUNE handling even more difficult,
but I think it's worth to also handle this transparently in the
assembler.
Thiemo
next prev parent reply other threads:[~2005-02-22 22:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-22 19:24 Maciej W. Rozycki
2005-02-22 20:21 ` Daniel Jacobowitz
2005-02-22 21:15 ` Maciej W. Rozycki
2005-02-22 21:24 ` Daniel Jacobowitz
2005-02-22 23:38 ` Thiemo Seufer
2005-02-22 23:53 ` Maciej W. Rozycki
2005-02-23 0:05 ` Thiemo Seufer
2005-02-23 0:06 ` Eric Christopher
2005-02-23 0:57 ` Thiemo Seufer [this message]
2005-02-23 8:32 ` Eric Christopher
2005-02-23 8:34 ` Thiemo Seufer
2005-02-23 9:38 ` Eric Christopher
2005-02-23 9:47 ` Thiemo Seufer
2005-02-23 9:57 ` Thiemo Seufer
2005-02-23 14:26 ` Richard Sandiford
2005-02-23 16:39 ` Thiemo Seufer
2005-02-23 17:05 ` Richard Sandiford
2005-02-23 19:22 ` Maciej W. Rozycki
2005-02-24 1:47 ` Thiemo Seufer
2005-02-24 15:53 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050222225421.GF7729@rembrandt.csv.ica.uni-stuttgart.de \
--to=ica2_ts@csv.ica.uni-stuttgart.de \
--cc=binutils@sources.redhat.com \
--cc=echristo@redhat.com \
--cc=macro@linux-mips.org \
--cc=macro@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).