public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "H. J. Lu" <hjl@lucon.org>
To: Nick Clifton <nickc@redhat.com>
Cc: binutils@sources.redhat.com
Subject: Re: PATCH: Test the just built windres/dlltool only
Date: Wed, 23 Feb 2005 02:26:00 -0000	[thread overview]
Message-ID: <20050222233022.GA13476@lucon.org> (raw)
In-Reply-To: <421B652F.9010202@redhat.com>

On Tue, Feb 22, 2005 at 05:00:31PM +0000, Nick Clifton wrote:
> Hi H. J.
> 
> >My PATH has binaries for my host machine, which are irrelevant to the
> >target for my binutils built tree. I don't think
> >
> ># configure
> ># make
> ># make check
> >
> >should test any of my install binaries. "make check" should assume
> >my installed binaries are OK. 
> 
> But by this argument, your patch ought to be extended to all of the 
> programs checked in the default.exp file, not just windres and dlltool.
> 

windres and dlltool are only enabled for certain targets. It isn't
impossible that I have windres or dlltool in PATH for entirely
different purposes. I asked for windres nor dlltool not to be
built. It is kind of odd for "make check" to check my windres or
dlltool behind my back.

> Plus I do not think that it is always reasonable to assume that 
> installed binaries are OK.  Users should be able to test them if they 
> are worried that they contain bugs, or if they want to compare the 
> behaviour of an installed set of tools against another set.

But I don't think it is the best way to test the installed binutils.
Have you tried to test the installed binutils in the build directory?
Can you can show me how my patch prenvents you from testing the
installed binutils?


H.J.

  reply	other threads:[~2005-02-22 23:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-21  8:37 H. J. Lu
2005-02-21  9:59 ` Daniel Jacobowitz
2005-02-21 10:29   ` H. J. Lu
2005-02-21 20:38     ` Nick Clifton
2005-02-21 21:09       ` H. J. Lu
2005-02-22 19:23         ` Nick Clifton
2005-02-23  2:26           ` H. J. Lu [this message]
2005-02-23 16:11             ` Nick Clifton
2005-02-24  5:37               ` H. J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050222233022.GA13476@lucon.org \
    --to=hjl@lucon.org \
    --cc=binutils@sources.redhat.com \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).