Re: PATCH: Test the just built windres/dlltool only

["H. J. Lu" <hjl@lucon.org>]

On Wed, Feb 23, 2005 at 02:31:49PM +0000, Nick Clifton wrote:
> Hi H. J.
> 
> >>But by this argument, your patch ought to be extended to all of the 
> >>programs checked in the default.exp file, not just windres and dlltool.
> 
> >windres and dlltool are only enabled for certain targets. It isn't
> >impossible that I have windres or dlltool in PATH for entirely
> >different purposes. I asked for windres nor dlltool not to be
> >built. It is kind of odd for "make check" to check my windres or
> >dlltool behind my back.
> 
> I agree - especially if "make check" is going to check in-build-tree 
> versions of the other commands.  It certainly ought to be consistent, 
> either checking all in-build-tree commands or all in-installed-tree 
> commands.  The point I was making was that your patch appeared to be 
> treating windres and dlltool as special cases when really this ought to 
> be an all or nothing approach as to which tools are tested.
> 
> >But I don't think it is the best way to test the installed binutils.
> >Have you tried to test the installed binutils in the build directory?
> 
> Err well I do not install binaries into a build directory, I install 
> them into a completely separate directory.  But I have tested installed 
> binaries that were created from a build tree.  (Usually because there is 
> a bug in the install process somewhere and I want the testsuite to help 
> me track down the problem).
> 
> >Can you can show me how my patch prevents you from testing the
> >installed binutils?
> 
> Sure, try this:
> 
>   * Build a mingw32-pe targeted toolchain (including gcc).
>   * Install at least gcc and the binutils somewhere.
>   * Go to the binutils build directory and run "make check".  You will 
> test the built executables in the build directory.  Save the 
> binutils.log for later comparison.
>   * Then run "make clean" to get rid of the built executables and add 
> the installed bin directory to your search path.  Rerun "make check". 
> You will test the installed executables using the build directory as a 
> test framework.  Save the binutils.log again.  It should be essentially 
> the same as the results from the in-build-tree test.
>   * Now apply your patch to default.exp and rerun the "make check". 
> This time the installed windres and dlltool will not be tested.
> 

I put the following commands in my ~/.dejagnurc. I don't have to do
"make clean" to test the installed binutils. If anything goes wrong,
I don't have to do a "make" again.


H.J.
----
set AR ar
set ar ar
set AS as
set as as
set NM nm
set NM nm
set DLLTOOL dlltool
set dlltool dlltool
set LD ld
set ld ld
set OBJCOPY objcopy
set objcopy objcopy
set OBJDUMP objdump
set objdump objdump
set READELF readelf
set readelf readelf
set SIZE size
set size size
set STRIP strip
set strip strip
set WINDRES windres
set windres windres