From: Alan Modra <amodra@bigpond.net.au>
To: binutils@sources.redhat.com
Subject: Re: compiling binutils with -DDEBUG
Date: Tue, 01 Mar 2005 11:04:00 -0000 [thread overview]
Message-ID: <20050301110311.GO5299@bubble.modra.org> (raw)
In-Reply-To: <20050301104949.GN5299@bubble.modra.org>
On Tue, Mar 01, 2005 at 09:19:49PM +1030, Alan Modra wrote:
> I did a little analysis. Nowadays, the assertion is always false for
> BFD_ASSEMBLER because symbols have been resolved (write.c:1857) by the
> time this code is reached. The following would probably fix the
> assertion, but I don't think it's worth worrying about.
* config/obj-coff.c (fixup_segment): Delete sy_mri_common assertion.
Index: gas/config/obj-coff.c
===================================================================
RCS file: /cvs/src/src/gas/config/obj-coff.c,v
retrieving revision 1.78
diff -u -p -r1.78 obj-coff.c
--- gas/config/obj-coff.c 22 Feb 2005 00:50:05 -0000 1.78
+++ gas/config/obj-coff.c 1 Mar 2005 10:51:57 -0000
@@ -4290,7 +4290,6 @@ fixup_segment (segP, this_segment_type)
if (add_symbolP != NULL
&& add_symbolP->sy_mri_common)
{
- know (add_symbolP->sy_value.X_op == O_symbol);
add_number += S_GET_VALUE (add_symbolP);
fixP->fx_offset = add_number;
add_symbolP = fixP->fx_addsy = add_symbolP->sy_value.X_add_symbol;
--
Alan Modra
IBM OzLabs - Linux Technology Centre
next prev parent reply other threads:[~2005-03-01 11:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-01 2:01 Alan Modra
2005-03-01 2:36 ` Ian Lance Taylor
2005-03-01 10:50 ` Alan Modra
2005-03-01 11:04 ` Alan Modra [this message]
2005-03-01 14:25 ` Ian Lance Taylor
2005-03-01 22:02 ` Alan Modra
2005-03-02 1:40 ` Ian Lance Taylor
2005-03-02 2:40 ` Alan Modra
2005-03-02 3:35 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050301110311.GO5299@bubble.modra.org \
--to=amodra@bigpond.net.au \
--cc=binutils@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).