From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 893 invoked by alias); 1 Mar 2005 11:04:04 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 32178 invoked from network); 1 Mar 2005 11:03:15 -0000 Received: from unknown (HELO imta04ps.mx.bigpond.com) (144.140.83.141) by sourceware.org with SMTP; 1 Mar 2005 11:03:15 -0000 Received: from modra.org ([144.136.221.26]) by imta04ps.mx.bigpond.com with ESMTP id <20050301110312.YBAA13116.imta04ps.mx.bigpond.com@modra.org> for ; Tue, 1 Mar 2005 11:03:12 +0000 Received: by bubble.modra.org (Postfix, from userid 500) id CA4C319F699; Tue, 1 Mar 2005 21:33:11 +1030 (CST) Date: Tue, 01 Mar 2005 11:04:00 -0000 From: Alan Modra To: binutils@sources.redhat.com Subject: Re: compiling binutils with -DDEBUG Message-ID: <20050301110311.GO5299@bubble.modra.org> Mail-Followup-To: binutils@sources.redhat.com References: <20050301020120.GJ5299@bubble.modra.org> <20050301104949.GN5299@bubble.modra.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050301104949.GN5299@bubble.modra.org> User-Agent: Mutt/1.4i X-SW-Source: 2005-03/txt/msg00015.txt.bz2 On Tue, Mar 01, 2005 at 09:19:49PM +1030, Alan Modra wrote: > I did a little analysis. Nowadays, the assertion is always false for > BFD_ASSEMBLER because symbols have been resolved (write.c:1857) by the > time this code is reached. The following would probably fix the > assertion, but I don't think it's worth worrying about. * config/obj-coff.c (fixup_segment): Delete sy_mri_common assertion. Index: gas/config/obj-coff.c =================================================================== RCS file: /cvs/src/src/gas/config/obj-coff.c,v retrieving revision 1.78 diff -u -p -r1.78 obj-coff.c --- gas/config/obj-coff.c 22 Feb 2005 00:50:05 -0000 1.78 +++ gas/config/obj-coff.c 1 Mar 2005 10:51:57 -0000 @@ -4290,7 +4290,6 @@ fixup_segment (segP, this_segment_type) if (add_symbolP != NULL && add_symbolP->sy_mri_common) { - know (add_symbolP->sy_value.X_op == O_symbol); add_number += S_GET_VALUE (add_symbolP); fixP->fx_offset = add_number; add_symbolP = fixP->fx_addsy = add_symbolP->sy_value.X_add_symbol; -- Alan Modra IBM OzLabs - Linux Technology Centre