From: Alan Modra <amodra@bigpond.net.au>
To: Jakub Jelinek <jakub@redhat.com>
Cc: binutils@sources.redhat.com
Subject: Re: [PATCH] _bfd_ar_spacepad
Date: Tue, 08 Mar 2005 01:07:00 -0000 [thread overview]
Message-ID: <20050308010724.GY15642@bubble.modra.org> (raw)
In-Reply-To: <20050307104753.GQ4777@sunsite.mff.cuni.cz>
On Mon, Mar 07, 2005 at 11:47:53AM +0100, Jakub Jelinek wrote:
> * libbfd-in.h (_bfd_ar_spacepad): New prototype.
> * libbfd.h: Rebuilt.
> * archive.c (_bfd_ar_spacepad): New function.
> (_bfd_construct_extended_name_table, _bfd_write_archive_contents,
> bsd_write_armap, _bfd_archive_bsd_update_armap_timestamp,
> coff_write_armap): Use it.
> (bfd_ar_hdr_from_filesystem): Likewise. Fix HP-UX large
> uid/gid support.
> * archive64.c (bfd_elf64_archive_write_armap): Use _bfd_ar_spacepad.
I like it.
> + _bfd_ar_spacepad (hdr->ar_name + 1, maxname - 1, "%-ld",
> + (unsigned) (strptr - *tabloc));
Remove the cast here, or make it (unsigned long). Seeing "%ld" and
(unsigned) just looks wrong when scanning the code.
> + _bfd_ar_spacepad (hdr.ar_size, sizeof (hdr.ar_size), "%-10ld",
> + (int) ((elength + 1) & ~(bfd_size_type) 1));
Similarly, use (long) here or remove the cast.
> + _bfd_ar_spacepad (hdr.ar_size, sizeof (hdr.ar_size), "%-10ld", (int) mapsize);
Likewise. Also in archive64.c.
--
Alan Modra
IBM OzLabs - Linux Technology Centre
next prev parent reply other threads:[~2005-03-08 1:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-07 10:48 Jakub Jelinek
2005-03-08 1:07 ` Alan Modra [this message]
2005-03-09 12:39 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050308010724.GY15642@bubble.modra.org \
--to=amodra@bigpond.net.au \
--cc=binutils@sources.redhat.com \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).