[RFA] Fix compilation warning in libiberty.h

[Joel Brobecker <brobecker@adacore.com>]

[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]

Hello,

I noticed that the compiler emits a warning when building bfd.c
in libiberty.h. The compiler we are using is GNAT Pro based on
GCC 3.4.4. Here is the warning we get:

gcc -DHAVE_CONFIG_H -I. -I.././bfd -I. -D_GNU_SOURCE -I. -I.././bfd -I.././bfd/../include -I.././bfd/../intl -I../intl -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Werror -g -O2 -c bfd.c -o bfd.o
In file included from bfd.c:209:
.././bfd/../include/libiberty.h:80: warning: function declaration isn't a prototype

The problem is that this breaks the build because of the -Werror.

I think the problem is that the prototype is missing a ``void'' keyword.
This fixes the warning. The trouble I had was whether I wanted to use
the PARAMS macro or not. I seem to remember that we wanted to get away
from them, but then the rest of the file uses it. I kept it for now,
for better consistency.

Joel Brobecker  <brobecker@adacore.com>

        * include/libiberty.h,v (basename): Fix prototype definition.

Tested by building GDB on sparc-solaris 2.8.
OK to apply?

Thanks,
-- 
Joel

[-- Attachment #2: libiberty.h.diff --]
[-- Type: text/plain, Size: 736 bytes --]

Index: include/libiberty.h
===================================================================
RCS file: /cvs/src/src/include/libiberty.h,v
retrieving revision 1.31
diff -u -p -r1.31 libiberty.h
--- include/libiberty.h	10 Mar 2005 01:05:51 -0000	1.31
+++ include/libiberty.h	18 Mar 2005 17:38:07 -0000
@@ -77,7 +77,7 @@ extern char **dupargv PARAMS ((char **))
 #if defined (__GNU_LIBRARY__ ) || defined (__linux__) || defined (__FreeBSD__) || defined (__OpenBSD__) || defined(__NetBSD__) || defined (__CYGWIN__) || defined (__CYGWIN32__) || defined (__MINGW32__) || defined (HAVE_DECL_BASENAME)
 extern char *basename PARAMS ((const char *));
 #else
-extern char *basename ();
+extern char *basename PARAMS ((void));
 #endif
 #endif