From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32299 invoked by alias); 19 Mar 2005 18:37:13 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 32242 invoked from network); 19 Mar 2005 18:37:08 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 19 Mar 2005 18:37:08 -0000 Received: from drow by nevyn.them.org with local (Exim 4.44 #1 (Debian)) id 1DCiog-0005vx-LF; Sat, 19 Mar 2005 13:36:54 -0500 Date: Sun, 20 Mar 2005 01:44:00 -0000 From: Daniel Jacobowitz To: "H. J. Lu" Cc: Hans-Peter Nilsson , binutils@sources.redhat.com Subject: Re: Committed, MMIX: Fix 64-bit host (opcodes/mmix-opc.c) Message-ID: <20050319183654.GA9412@nevyn.them.org> Mail-Followup-To: "H. J. Lu" , Hans-Peter Nilsson , binutils@sources.redhat.com References: <20050318191029.GA31706@lucon.org> <20050318195417.GA32320@lucon.org> <20050318195955.GB4222@nevyn.them.org> <20050318200349.GA32559@lucon.org> <20050318200632.GA4515@nevyn.them.org> <20050318202433.GA367@lucon.org> <20050318233117.GA3827@lucon.org> <20050319183322.GA19663@lucon.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050319183322.GA19663@lucon.org> User-Agent: Mutt/1.5.6+20040907i X-SW-Source: 2005-03/txt/msg00578.txt.bz2 On Sat, Mar 19, 2005 at 10:33:22AM -0800, H. J. Lu wrote: > On Fri, Mar 18, 2005 at 11:30:41PM -0500, Hans-Peter Nilsson wrote: > > On Fri, 18 Mar 2005, H. J. Lu wrote: > > > Please make sure that there are no unexpected failures in gas. > > > > That's what I meant of course. Now it does; if there are any > > related ld failures they disappear in the breakage due to empty > > size section removal. > > > > (For the record, the value of (X << 24) where X=0xff depends on > > the size of int and the type of the expression. Easiest fixed > > by forcing the type of X.) > > > > I'll commit this to 2.16 too. > > > > * mmix-opc.c (O, Z): Force expression as unsigned long. > > > > It isn't enough. I checked in the following patch to mainline to > fix it. I suggest you check it to 2.16 branch. Why do you believe the type of the shift count matters here? > -#define O(m) ((unsigned long) (m) << 24UL), ((~(unsigned long) (m) & 255) << 24) > +#define O(m) ((unsigned long) (m) << 24UL), ((~(unsigned long) (m) & 255) << 24UL) -- Daniel Jacobowitz CodeSourcery, LLC