public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@bigpond.net.au>
To: "H. J. Lu" <hjl@lucon.org>
Cc: binutils@sources.redhat.com
Subject: Re: PATCH: Store ELF section index for input file
Date: Mon, 21 Mar 2005 02:07:00 -0000	[thread overview]
Message-ID: <20050320223647.GP21148@bubble.modra.org> (raw)
In-Reply-To: <20050320191857.GA24114@lucon.org>

On Sun, Mar 20, 2005 at 11:18:57AM -0800, H. J. Lu wrote:
> 2005-03-20  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	* elf-bfd.h (elf_backend_data): Add int to
> 	elf_backend_section_from_shdr.
> 	(bfd_elf_section_data): Update this_idx to indicate it will be
> 	used for input file.
> 	(_bfd_elf_make_section_from_shdr): Add int.
> 	* elfxx-mips.h (_bfd_mips_elf_section_from_shdr): Likewise.
> 
> 	* elf.c (_bfd_elf_make_section_from_shdr): Take section index
> 	and use it to set this_idx in bfd_elf_section_data.
> 	(bfd_section_from_shdr): Pass shindex to
> 	_bfd_elf_make_section_from_shdr.
> 	(_bfd_elf_section_from_bfd_section): Use this_idx in
> 	bfd_elf_section_data to find section index.
> 
> 	* elf32-arm.c (elf32_arm_section_from_shdr): Take section
> 	index and pass it to _bfd_elf_make_section_from_shdr.
> 	* elf32-i370.c(i370_elf_section_from_shdr): Likewise.
> 	* elf32-ppc.c (ppc_elf_section_from_shdr): Likewise.
> 	* elf32-sh64.c (sh64_backend_section_from_shdr): Likewise.
> 	* elf32-v850.c (v850_elf_section_from_shdr): Likewise.
> 	* elf64-alpha.c (elf64_alpha_section_from_shdr): Likewise.
> 	* elf64-hppa.c (elf64_hppa_section_from_shdr): Likewise.
> 	* elf64-x86-64.c (elf64_x86_64_section_from_shdr): Likewise.
> 	* elfxx-ia64.c (elfNN_ia64_section_from_shdr): Likewise.
> 	* elfxx-mips.c (_bfd_mips_elf_section_from_shdr): Likewise.

OK for mainline.

> @@ -1060,7 +1060,8 @@ struct bfd_elf_section_data
>    unsigned int rel_count2;
>  
>    /* The ELF section number of this section.  Only used for an output
> -     file.  */
> +     file.  Also used for an input file as the index into the ELF
> +     section array, elf_elfsections.  */

Change this to simply "/* The ELF section number of this section.  */"

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

      reply	other threads:[~2005-03-20 22:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-17 22:03 RFC: " H. J. Lu
2005-03-17 23:06 ` PATCH: " H. J. Lu
2005-03-19 18:57   ` Alan Modra
2005-03-19 19:02     ` H. J. Lu
2005-03-20 13:22       ` Alan Modra
2005-03-20 13:38         ` H. J. Lu
2005-03-21  0:27           ` H. J. Lu
2005-03-21  2:07             ` Alan Modra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050320223647.GP21148@bubble.modra.org \
    --to=amodra@bigpond.net.au \
    --cc=binutils@sources.redhat.com \
    --cc=hjl@lucon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).