From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27275 invoked by alias); 23 Mar 2005 02:05:17 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 27140 invoked from network); 23 Mar 2005 02:05:01 -0000 Received: from unknown (HELO gizmo07bw.bigpond.com) (144.140.70.42) by sourceware.org with SMTP; 23 Mar 2005 02:05:01 -0000 Received: (qmail 11499 invoked from network); 23 Mar 2005 02:04:58 -0000 Received: from unknown (HELO bwmam12.bigpond.com) (144.135.24.103) by gizmo07bw.bigpond.com with SMTP; 23 Mar 2005 02:04:58 -0000 Received: from cpe-144-136-221-26.sa.bigpond.net.au ([144.136.221.26]) by bwmam12.bigpond.com(MAM REL_3_4_2a 189/37488143) with SMTP id 37488143; Wed, 23 Mar 2005 12:04:58 +1000 Received: by bubble.modra.org (Postfix, from userid 500) id C77831A0D20; Wed, 23 Mar 2005 12:34:57 +1030 Date: Wed, 23 Mar 2005 09:28:00 -0000 From: Alan Modra To: "H. J. Lu" Cc: binutils@sources.redhat.com Subject: Re: PATCH: Add _bfd_elf_provide_symbol Message-ID: <20050323020457.GM30711@bubble.modra.org> Mail-Followup-To: "H. J. Lu" , binutils@sources.redhat.com References: <20050321140003.GK1260@bubble.modra.org> <20050322031617.GD27445@bubble.modra.org> <20050322041855.GA22732@lucon.org> <20050322050314.GE27445@bubble.modra.org> <20050322170758.GA1330@lucon.org> <20050322204903.GA4693@lucon.org> <20050322224422.GA6367@lucon.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050322224422.GA6367@lucon.org> User-Agent: Mutt/1.4i X-SW-Source: 2005-03/txt/msg00695.txt.bz2 On Tue, Mar 22, 2005 at 02:44:22PM -0800, H. J. Lu wrote: > Here is an upated patch. _bfd_elf_provide_symbol should presever > st_other. Also it needs to set forced_local to 1. Otherwise, we will > get global hidden symbols. We don't need those array symbols for > shared libraries. Looks good. OK for mainline, and the branch too unless Daniel disagrees. -- Alan Modra IBM OzLabs - Linux Technology Centre