* Your ld changes caused cris-axis-elf regressions
@ 2005-03-23 9:59 Hans-Peter Nilsson
2005-03-23 10:04 ` H. J. Lu
0 siblings, 1 reply; 6+ messages in thread
From: Hans-Peter Nilsson @ 2005-03-23 9:59 UTC (permalink / raw)
To: binutils
(Forgot to CC the list again. Agh!)
This change
+ 2005-03-22 H.J. Lu <hongjiu.lu@intel.com>
+
+ * emultempl/elf32.em (gld${EMULATION_NAME}_provide_bound_symbols): New
+ (gld${EMULATION_NAME}_finish): Call
+ gld${EMULATION_NAME}_provide_bound_symbols to provide
+ __preinit_array_start, __preinit_array_end, __init_array_start,
+ __init_array_end, __fini_array_start and __fini_array_end.
+
+ * scripttempl/elf.sc: Don't provide __preinit_array_start,
+ __preinit_array_end, __init_array_start, __init_array_end,
+ __fini_array_start nor __fini_array_end.
+
caused these FAILs: (Likely similarly for other ld-* targets
too, including mmix-knuth-mmixware ;-)
FAIL: ld-cris/libdso-10
FAIL: ld-cris/libdso-11
FAIL: ld-cris/libdso-12
FAIL: ld-cris/libdso-14
FAIL: ld-cris/libdso-2
FAIL: ld-cris/expdyn5
FAIL: ld-cris/expdyn6
FAIL: ld-cris/expdyn7
FAIL: ld-cris/gotplt1
FAIL: ld-cris/gotplt2
FAIL: ld-cris/gotplt3
FAIL: ld-cris/locref1
FAIL: ld-cris/locref2
FAIL: ld-cris/nodyn5
FAIL: ld-cris/pv32-1
FAIL: ld-cris/weakref2
brgds, H-P
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Your ld changes caused cris-axis-elf regressions
2005-03-23 9:59 Your ld changes caused cris-axis-elf regressions Hans-Peter Nilsson
@ 2005-03-23 10:04 ` H. J. Lu
2005-03-23 11:18 ` Hans-Peter Nilsson
0 siblings, 1 reply; 6+ messages in thread
From: H. J. Lu @ 2005-03-23 10:04 UTC (permalink / raw)
To: Hans-Peter Nilsson; +Cc: binutils
On Wed, Mar 23, 2005 at 06:00:40AM +0100, Hans-Peter Nilsson wrote:
> (Forgot to CC the list again. Agh!)
>
> This change
>
> + 2005-03-22 H.J. Lu <hongjiu.lu@intel.com>
> +
> + * emultempl/elf32.em (gld${EMULATION_NAME}_provide_bound_symbols): New
> + (gld${EMULATION_NAME}_finish): Call
> + gld${EMULATION_NAME}_provide_bound_symbols to provide
> + __preinit_array_start, __preinit_array_end, __init_array_start,
> + __init_array_end, __fini_array_start and __fini_array_end.
> +
> + * scripttempl/elf.sc: Don't provide __preinit_array_start,
> + __preinit_array_end, __init_array_start, __init_array_end,
> + __fini_array_start nor __fini_array_end.
> +
>
> caused these FAILs: (Likely similarly for other ld-* targets
> too, including mmix-knuth-mmixware ;-)
I have no problem with mmix-knuth-mmixware crossing from Linux/x86_64.
>
> FAIL: ld-cris/libdso-10
> FAIL: ld-cris/libdso-11
> FAIL: ld-cris/libdso-12
> FAIL: ld-cris/libdso-14
> FAIL: ld-cris/libdso-2
> FAIL: ld-cris/expdyn5
> FAIL: ld-cris/expdyn6
> FAIL: ld-cris/expdyn7
> FAIL: ld-cris/gotplt1
> FAIL: ld-cris/gotplt2
> FAIL: ld-cris/gotplt3
> FAIL: ld-cris/locref1
> FAIL: ld-cris/locref2
> FAIL: ld-cris/nodyn5
> FAIL: ld-cris/pv32-1
> FAIL: ld-cris/weakref2
>
The change I made removed an unnecessary "ALIGN" before .init_array
in elf.sc, which may change memory layout. I don't have any problems
with ia32, ia64 and x86_64.
BTW, I got many gas failures for cris-elf on Linux/x86_64. Is cris-elf
64bit clean? Please fix gas failures first. I will update ld-cris tests
later.
H.J.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Your ld changes caused cris-axis-elf regressions
2005-03-23 10:04 ` H. J. Lu
@ 2005-03-23 11:18 ` Hans-Peter Nilsson
2005-03-24 3:57 ` H. J. Lu
0 siblings, 1 reply; 6+ messages in thread
From: Hans-Peter Nilsson @ 2005-03-23 11:18 UTC (permalink / raw)
To: hjl; +Cc: hans-peter.nilsson, binutils
> Date: Tue, 22 Mar 2005 21:31:21 -0800
> From: "H. J. Lu" <hjl@lucon.org>
> BTW, I got many gas failures for cris-elf on Linux/x86_64. Is cris-elf
> 64bit clean? Please fix gas failures first. I will update ld-cris tests
> later.
I have some prior knowledge of some of the GAS failures; those
are benevolent. But I'll have another look. Thanks for looking
into it.
(Now I know why they called it DejaGNU. :-)
brgds, H-P
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Your ld changes caused cris-axis-elf regressions
2005-03-23 11:18 ` Hans-Peter Nilsson
@ 2005-03-24 3:57 ` H. J. Lu
2005-03-24 10:35 ` Hans-Peter Nilsson
2005-03-24 10:39 ` cris-elf GAS 64-bit host ffails (was: Re: Your ld changes caused cris-axis-elf regressions) Hans-Peter Nilsson
0 siblings, 2 replies; 6+ messages in thread
From: H. J. Lu @ 2005-03-24 3:57 UTC (permalink / raw)
To: Hans-Peter Nilsson; +Cc: binutils
On Wed, Mar 23, 2005 at 06:37:14AM +0100, Hans-Peter Nilsson wrote:
> > Date: Tue, 22 Mar 2005 21:31:21 -0800
> > From: "H. J. Lu" <hjl@lucon.org>
>
> > BTW, I got many gas failures for cris-elf on Linux/x86_64. Is cris-elf
> > 64bit clean? Please fix gas failures first. I will update ld-cris tests
> > later.
>
> I have some prior knowledge of some of the GAS failures; those
> are benevolent. But I'll have another look. Thanks for looking
> into it.
>
> (Now I know why they called it DejaGNU. :-)
>
I checked the following patch to fix cris dissambler on 64bit host.
I also updated ld-cris tests.
BTW, I still got some gas failures.
H.J.
----
2005-03-23 H.J. Lu <hongjiu.lu@intel.com>
* cris-dis.c (print_with_operands): Use ~31L for long instead
of ~31.
--- cris-dis.c.64 2005-03-03 08:55:56.000000000 -0800
+++ cris-dis.c 2005-03-23 11:18:28.949308548 -0800
@@ -1375,7 +1375,7 @@ print_with_operands (opcodep, insn, buff
break;
case 'i':
- tp = format_dec ((insn & 32) ? (insn & 31) | ~31 : insn & 31, tp, 1);
+ tp = format_dec ((insn & 32) ? (insn & 31) | ~31L : insn & 31, tp, 1);
break;
case 'P':
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Your ld changes caused cris-axis-elf regressions
2005-03-24 3:57 ` H. J. Lu
@ 2005-03-24 10:35 ` Hans-Peter Nilsson
2005-03-24 10:39 ` cris-elf GAS 64-bit host ffails (was: Re: Your ld changes caused cris-axis-elf regressions) Hans-Peter Nilsson
1 sibling, 0 replies; 6+ messages in thread
From: Hans-Peter Nilsson @ 2005-03-24 10:35 UTC (permalink / raw)
To: hjl; +Cc: hans-peter.nilsson, binutils
> Date: Wed, 23 Mar 2005 11:24:33 -0800
> From: "H. J. Lu" <hjl@lucon.org>
> I checked the following patch to fix cris dissambler on 64bit host.
> I also updated ld-cris tests.
Thanks!
> BTW, I still got some gas failures.
I'll look into them today.
brgds, H-P
^ permalink raw reply [flat|nested] 6+ messages in thread
* cris-elf GAS 64-bit host ffails (was: Re: Your ld changes caused cris-axis-elf regressions)
2005-03-24 3:57 ` H. J. Lu
2005-03-24 10:35 ` Hans-Peter Nilsson
@ 2005-03-24 10:39 ` Hans-Peter Nilsson
1 sibling, 0 replies; 6+ messages in thread
From: Hans-Peter Nilsson @ 2005-03-24 10:39 UTC (permalink / raw)
To: hjl; +Cc: hans-peter.nilsson, binutils
> Date: Wed, 23 Mar 2005 11:24:33 -0800
> From: "H. J. Lu" <hjl@lucon.org>
> BTW, I still got some gas failures.
I presume these are what you saw?
(Quoting the errors would have helped me make sure, but thanks
anyway for reporting.)
XPASS: gas/cris/shexpr-1
XPASS: gas/cris/range-err-1.s (test for errors, line 29)
XPASS: gas/cris/range-err-1.s (test for errors, line 38)
XPASS: gas/cris/range-err-1.s (test for errors, line 50)
FAIL: gas/cris/range-err-1.s (test for errors, line 64)
FAIL: gas/cris/range-err-1.s (test for errors, line 67)
FAIL: gas/cris/range-err-1.s (test for excess errors)
I've fixed the FAILs as follows. The XPASSes remain, as I can't
xfail these tests for 32-bit hosts only. I agree they're a wart
but I don't see a pressing need to make them go away. If you're
not happy with that, please suggest a remedy.
The expected errors were expecting results from 32-bit
arithmetic; that's why they FAILed.
Committed.
gas/testsuite:
* gas/cris/range-err-1.s: Adjust expected messages for hosts with
64-bit longs.
Index: range-err-1.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/cris/range-err-1.s,v
retrieving revision 1.3
diff -p -c -u -p -r1.3 range-err-1.s
--- range-err-1.s 15 Jun 2003 23:46:37 -0000 1.3
+++ range-err-1.s 23 Mar 2005 23:53:16 -0000
@@ -61,9 +61,9 @@ start:
add.w 2781868,r13 ; { dg-error "Immediate value not in 16 bit range: 2781868" }
add.w -2701867,r13 ; { dg-error "Immediate value not in 16 bit range: -2701867" }
- add.w 0x9ec0ceac,r13 ; { dg-error "Immediate value not in 16 bit range: -1631531348" }
+ add.w 0x9ec0ceac,r13 ; { dg-error "Immediate value not in 16 bit range: (2663435948|-1631531348)" }
add.w -0x7ec0cead,r13 ; { dg-error "Immediate value not in 16 bit range: -2126565037" }
- add.w const_int_m32,r13 ; { dg-error "Immediate value not in 16 bit range: 781758389" }
+ add.w const_int_m32,r13 ; { dg-error "Immediate value not in 16 bit range: (-3513208907|781758389)" }
add.w const_int_32,r13 ; { dg-error "Immediate value not in 16 bit range: 462701867" }
add.w -(three2767+2),r5 ; { dg-error "Immediate value not in 16 bit range: -32769" }
brgds, H-P
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-03-24 0:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-03-23 9:59 Your ld changes caused cris-axis-elf regressions Hans-Peter Nilsson
2005-03-23 10:04 ` H. J. Lu
2005-03-23 11:18 ` Hans-Peter Nilsson
2005-03-24 3:57 ` H. J. Lu
2005-03-24 10:35 ` Hans-Peter Nilsson
2005-03-24 10:39 ` cris-elf GAS 64-bit host ffails (was: Re: Your ld changes caused cris-axis-elf regressions) Hans-Peter Nilsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).