From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: dj@redhat.com
Cc: ian@airs.com, gcc-patches@gcc.gnu.org, binutils@sourceware.org,
gdb@sourceware.org
Subject: Re: [PATCH/libiberty] Add missing <sys/types.h> in unlink-if-ordinary.c
Date: Mon, 28 Mar 2005 23:47:00 -0000 [thread overview]
Message-ID: <200503281442.j2SEgkJs023259@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <200503280235.j2S2Z4vS010751@greed.delorie.com> (message from DJ Delorie on Sun, 27 Mar 2005 21:35:04 -0500)
Date: Sun, 27 Mar 2005 21:35:04 -0500
From: DJ Delorie <dj@redhat.com>
> <sys/types.h> is not an ISO C header file. But it is in POSIX.1.
> And it is available on every Unix system. Because of that, it is
> available on every Unix workalike system.
At least since 7th Edition Unix.
Right, but the machines that wouldn't have it, probably would have K&R
compilers anyway. We haven't had a problem using it unprotected so
far, and there's even less reason to worry about it now.
Could on of you do me the favor of checking this in on the gcc side?
Looks like I don't have write permission there anymore. Attached is
an updated patch that also updates the copyright year.
Mark
Index: ChangeLog
from Mark Kettenis <kettenis@gnu.org>
* unlink-if-ordinary.c: Include <sys/types.h>.
Index: unlink-if-ordinary.c
===================================================================
RCS file: /cvs/gcc/gcc/libiberty/unlink-if-ordinary.c,v
retrieving revision 1.2
diff -u -p -r1.2 unlink-if-ordinary.c
--- unlink-if-ordinary.c 28 Mar 2005 01:28:01 -0000 1.2
+++ unlink-if-ordinary.c 28 Mar 2005 14:42:16 -0000
@@ -1,5 +1,5 @@
/* unlink-if-ordinary.c - remove link to a file unless it is special
- Copyright (C) 2004 Free Software Foundation, Inc.
+ Copyright (C) 2004, 2005 Free Software Foundation, Inc.
This file is part of the libiberty library. This library is free
software; you can redistribute it and/or modify it under the
@@ -39,6 +39,8 @@ was made to unlink the file because it i
#include "config.h"
#endif
+#include <sys/types.h>
+
#ifdef HAVE_UNISTD_H
#include <unistd.h>
#endif
next prev parent reply other threads:[~2005-03-28 14:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-27 18:48 Mark Kettenis
2005-03-27 20:26 ` Andrew Haley
2005-03-27 21:38 ` Mark Kettenis
2005-03-28 14:43 ` DJ Delorie
2005-03-28 16:27 ` Ian Lance Taylor
2005-03-28 17:17 ` DJ Delorie
2005-03-28 23:47 ` Mark Kettenis [this message]
2005-03-29 0:45 ` DJ Delorie
2005-03-28 6:57 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200503281442.j2SEgkJs023259@elgar.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=binutils@sourceware.org \
--cc=dj@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb@sourceware.org \
--cc=ian@airs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).