From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27444 invoked by alias); 28 Mar 2005 22:54:08 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 27398 invoked from network); 28 Mar 2005 22:54:00 -0000 Received: from unknown (HELO mx01.qsc.de) (213.148.129.14) by sourceware.org with SMTP; 28 Mar 2005 22:54:00 -0000 Received: from port-195-158-169-58.dynamic.qsc.de ([195.158.169.58] helo=hattusa.textio) by mx01.qsc.de with esmtp (Exim 3.35 #1) id 1DG37P-0002IY-00 for binutils@sources.redhat.com; Tue, 29 Mar 2005 00:53:59 +0200 Received: from ths by hattusa.textio with local (Exim 4.50) id 1DG1a3-0000Qx-Nt for binutils@sources.redhat.com; Mon, 28 Mar 2005 23:15:27 +0200 Date: Tue, 29 Mar 2005 05:11:00 -0000 To: binutils@sources.redhat.com Subject: Re: [RFA] Fix compilation warnings in irix-core.c Message-ID: <20050328211527.GA1623@hattusa.textio> References: <20050328224444.GS2295@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050328224444.GS2295@adacore.com> User-Agent: Mutt/1.5.6+20040907i From: Thiemo Seufer X-SW-Source: 2005-03/txt/msg00831.txt.bz2 Joel Brobecker wrote: > Hello, > > GDB currently fails to build on mips/irix due to warnings now being > turned into errors. I am unfortunately lacking the time to look deeply > into this at the moment (I have asked one of my coworkers to help me > with that), but there was one file where the fixes were I think obvious. > Here is a patch for it: > > 2005-03-28 Joel Brobecker > > * irix-core.c (do_sections): Add parenthesis in expression > to avoid a compiler warning. > (irix_core_core_file_matches_executable_p): Add ATTRIBUTE_UNUSED > to unused parameters to avoid a compiler warning. > > The changes should be nops. The only question I had was regarding > the conversion to ISO C (ie have "int foo (char *bar) {" instead of > "int foo (bar) char * bar; {"). For now, I just left the file as is. > I think the conversion should be done in a patch of its own anyway. > > Tested by building GDB and running the GDB testsuite. > OK to apply? > > Thanks, > -- > Joel > Index: irix-core.c > =================================================================== > RCS file: /cvs/src/src/bfd/irix-core.c,v > retrieving revision 1.12 > diff -u -p -r1.12 irix-core.c > --- irix-core.c 24 Jun 2004 04:46:24 -0000 1.12 > +++ irix-core.c 28 Mar 2005 22:38:23 -0000 > @@ -152,7 +152,7 @@ do_sections (abfd, coreout) > continue; > > if (!make_bfd_asection (abfd, secname, > - SEC_ALLOC | SEC_LOAD+SEC_HAS_CONTENTS, > + SEC_ALLOC | (SEC_LOAD+SEC_HAS_CONTENTS), > vmap.v_len, vmap.v_vaddr, vmap.v_offset)) This should probably be SEC_ALLOC | SEC_LOAD | SEC_HAS_CONTENTS anyways. Thiemo