From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21002 invoked by alias); 28 Mar 2005 22:44:59 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 20944 invoked from network); 28 Mar 2005 22:44:47 -0000 Received: from unknown (HELO priv-edtnes28.telusplanet.net) (199.185.220.223) by sourceware.org with SMTP; 28 Mar 2005 22:44:47 -0000 Received: from takamaka.act-europe.fr ([142.179.108.108]) by priv-edtnes28.telusplanet.net (InterMail vM.6.01.04.00 201-2131-118-20041027) with ESMTP id <20050328224447.RNYV10221.priv-edtnes28.telusplanet.net@takamaka.act-europe.fr> for ; Mon, 28 Mar 2005 15:44:47 -0700 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id AB7FB47DC0; Mon, 28 Mar 2005 14:44:44 -0800 (PST) Date: Tue, 29 Mar 2005 04:32:00 -0000 From: Joel Brobecker To: binutils@sources.redhat.com Subject: [RFA] Fix compilation warnings in irix-core.c Message-ID: <20050328224444.GS2295@adacore.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="neYutvxvOLaeuPCA" Content-Disposition: inline User-Agent: Mutt/1.4i X-SW-Source: 2005-03/txt/msg00829.txt.bz2 --neYutvxvOLaeuPCA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 960 Hello, GDB currently fails to build on mips/irix due to warnings now being turned into errors. I am unfortunately lacking the time to look deeply into this at the moment (I have asked one of my coworkers to help me with that), but there was one file where the fixes were I think obvious. Here is a patch for it: 2005-03-28 Joel Brobecker * irix-core.c (do_sections): Add parenthesis in expression to avoid a compiler warning. (irix_core_core_file_matches_executable_p): Add ATTRIBUTE_UNUSED to unused parameters to avoid a compiler warning. The changes should be nops. The only question I had was regarding the conversion to ISO C (ie have "int foo (char *bar) {" instead of "int foo (bar) char * bar; {"). For now, I just left the file as is. I think the conversion should be done in a patch of its own anyway. Tested by building GDB and running the GDB testsuite. OK to apply? Thanks, -- Joel --neYutvxvOLaeuPCA Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="irix-core.c.diff" Content-length: 847 Index: irix-core.c =================================================================== RCS file: /cvs/src/src/bfd/irix-core.c,v retrieving revision 1.12 diff -u -p -r1.12 irix-core.c --- irix-core.c 24 Jun 2004 04:46:24 -0000 1.12 +++ irix-core.c 28 Mar 2005 22:38:23 -0000 @@ -152,7 +152,7 @@ do_sections (abfd, coreout) continue; if (!make_bfd_asection (abfd, secname, - SEC_ALLOC | SEC_LOAD+SEC_HAS_CONTENTS, + SEC_ALLOC | (SEC_LOAD+SEC_HAS_CONTENTS), vmap.v_len, vmap.v_vaddr, vmap.v_offset)) /* Fail. */ return 0; @@ -288,7 +288,7 @@ irix_core_core_file_failing_signal (abfd static bfd_boolean irix_core_core_file_matches_executable_p (core_bfd, exec_bfd) - bfd *core_bfd, *exec_bfd; + bfd *core_bfd ATTRIBUTE_UNUSED, *exec_bfd ATTRIBUTE_UNUSED; { return TRUE; /* XXX - FIXME */ } --neYutvxvOLaeuPCA--