From: Joel Brobecker <brobecker@adacore.com>
To: Eric Christopher <echristo@redhat.com>
Cc: binutils@sources.redhat.com
Subject: Re: [RFA] Fix compilation warnings in irix-core.c
Date: Tue, 29 Mar 2005 08:31:00 -0000 [thread overview]
Message-ID: <20050329042112.GB2545@adacore.com> (raw)
In-Reply-To: <1112053626.5223.13.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
Here is what I just checked in:
2005-03-28 Joel Brobecker <brobecker@adacore.com>
* irix-core.c (do_sections): Replace + by | in expression.
(irix_core_core_file_matches_executable_p): Add ATTRIBUTE_UNUSED
to unused parameters to avoid a compiler warning.
Tested on mips-irix by running the GDB testsuite. I got identical
results, as expected.
Next is ISO-ification...
Thanks,
--
Joel
[-- Attachment #2: irix-core.c.diff --]
[-- Type: text/plain, Size: 857 bytes --]
Index: irix-core.c
===================================================================
RCS file: /cvs/src/src/bfd/irix-core.c,v
retrieving revision 1.12
diff -u -p -r1.12 irix-core.c
--- irix-core.c 24 Jun 2004 04:46:24 -0000 1.12
+++ irix-core.c 29 Mar 2005 04:17:38 -0000
@@ -152,7 +152,7 @@ do_sections (abfd, coreout)
continue;
if (!make_bfd_asection (abfd, secname,
- SEC_ALLOC | SEC_LOAD+SEC_HAS_CONTENTS,
+ SEC_ALLOC | SEC_LOAD | SEC_HAS_CONTENTS,
vmap.v_len, vmap.v_vaddr, vmap.v_offset))
/* Fail. */
return 0;
@@ -288,7 +288,8 @@ irix_core_core_file_failing_signal (abfd
static bfd_boolean
irix_core_core_file_matches_executable_p (core_bfd, exec_bfd)
- bfd *core_bfd, *exec_bfd;
+ bfd *core_bfd ATTRIBUTE_UNUSED;
+ bfd *exec_bfd ATTRIBUTE_UNUSED;
{
return TRUE; /* XXX - FIXME */
}
prev parent reply other threads:[~2005-03-29 4:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-29 4:32 Joel Brobecker
2005-03-29 4:59 ` Daniel Jacobowitz
2005-03-29 5:11 ` Thiemo Seufer
2005-03-29 6:03 ` Eric Christopher
2005-03-29 6:19 ` Joel Brobecker
2005-03-29 6:29 ` Eric Christopher
2005-03-29 8:31 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050329042112.GB2545@adacore.com \
--to=brobecker@adacore.com \
--cc=binutils@sources.redhat.com \
--cc=echristo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).