[RFA] Fix compilation warnings in irix-core.c

[RFA] Fix compilation warnings in irix-core.c

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 960 bytes --]

Hello,

GDB currently fails to build on mips/irix due to warnings now being
turned into errors. I am unfortunately lacking the time to look deeply
into this at the moment (I have asked one of my coworkers to help me
with that), but there was one file where the fixes were I think obvious.
Here is a patch for it:

2005-03-28  Joel Brobecker  <brobecker@adacore.com>

        * irix-core.c (do_sections): Add parenthesis in expression
        to avoid a compiler warning.
        (irix_core_core_file_matches_executable_p): Add ATTRIBUTE_UNUSED
        to unused parameters to avoid a compiler warning.

The changes should be nops. The only question I had was regarding
the conversion to ISO C (ie have "int foo (char *bar) {" instead of
"int foo (bar) char * bar; {"). For now, I just left the file as is.
I think the conversion should be done in a patch of its own anyway.

Tested by building GDB and running the GDB testsuite.
OK to apply?

Thanks,
-- 
Joel

[-- Attachment #2: irix-core.c.diff --]
[-- Type: text/plain, Size: 847 bytes --]

Index: irix-core.c
===================================================================
RCS file: /cvs/src/src/bfd/irix-core.c,v
retrieving revision 1.12
diff -u -p -r1.12 irix-core.c
--- irix-core.c	24 Jun 2004 04:46:24 -0000	1.12
+++ irix-core.c	28 Mar 2005 22:38:23 -0000
@@ -152,7 +152,7 @@ do_sections (abfd, coreout)
 	continue;
 
       if (!make_bfd_asection (abfd, secname,
-			      SEC_ALLOC | SEC_LOAD+SEC_HAS_CONTENTS,
+			      SEC_ALLOC | (SEC_LOAD+SEC_HAS_CONTENTS),
 			      vmap.v_len, vmap.v_vaddr, vmap.v_offset))
 	/* Fail.  */
 	return 0;
@@ -288,7 +288,7 @@ irix_core_core_file_failing_signal (abfd
 
 static bfd_boolean
 irix_core_core_file_matches_executable_p (core_bfd, exec_bfd)
-     bfd *core_bfd, *exec_bfd;
+     bfd *core_bfd ATTRIBUTE_UNUSED, *exec_bfd ATTRIBUTE_UNUSED;
 {
   return TRUE;			/* XXX - FIXME */
 }

Re: [RFA] Fix compilation warnings in irix-core.c

[Daniel Jacobowitz]

On Mon, Mar 28, 2005 at 02:44:44PM -0800, Joel Brobecker wrote:
> Hello,
> 
> GDB currently fails to build on mips/irix due to warnings now being
> turned into errors. I am unfortunately lacking the time to look deeply
> into this at the moment (I have asked one of my coworkers to help me
> with that), but there was one file where the fixes were I think obvious.
> Here is a patch for it:
> 
> 2005-03-28  Joel Brobecker  <brobecker@adacore.com>
> 
>         * irix-core.c (do_sections): Add parenthesis in expression
>         to avoid a compiler warning.
>         (irix_core_core_file_matches_executable_p): Add ATTRIBUTE_UNUSED
>         to unused parameters to avoid a compiler warning.
> 
> The changes should be nops. The only question I had was regarding
> the conversion to ISO C (ie have "int foo (char *bar) {" instead of
> "int foo (bar) char * bar; {"). For now, I just left the file as is.
> I think the conversion should be done in a patch of its own anyway.

I agree.

> Tested by building GDB and running the GDB testsuite.
> OK to apply?

> -			      SEC_ALLOC | SEC_LOAD+SEC_HAS_CONTENTS,

How about just changing the + to an | ?


-- 
Daniel Jacobowitz
CodeSourcery, LLC

Re: [RFA] Fix compilation warnings in irix-core.c

[Thiemo Seufer]

Joel Brobecker wrote:
> Hello,
> 
> GDB currently fails to build on mips/irix due to warnings now being
> turned into errors. I am unfortunately lacking the time to look deeply
> into this at the moment (I have asked one of my coworkers to help me
> with that), but there was one file where the fixes were I think obvious.
> Here is a patch for it:
> 
> 2005-03-28  Joel Brobecker  <brobecker@adacore.com>
> 
>         * irix-core.c (do_sections): Add parenthesis in expression
>         to avoid a compiler warning.
>         (irix_core_core_file_matches_executable_p): Add ATTRIBUTE_UNUSED
>         to unused parameters to avoid a compiler warning.
> 
> The changes should be nops. The only question I had was regarding
> the conversion to ISO C (ie have "int foo (char *bar) {" instead of
> "int foo (bar) char * bar; {"). For now, I just left the file as is.
> I think the conversion should be done in a patch of its own anyway.
> 
> Tested by building GDB and running the GDB testsuite.
> OK to apply?
> 
> Thanks,
> -- 
> Joel

> Index: irix-core.c
> ===================================================================
> RCS file: /cvs/src/src/bfd/irix-core.c,v
> retrieving revision 1.12
> diff -u -p -r1.12 irix-core.c
> --- irix-core.c	24 Jun 2004 04:46:24 -0000	1.12
> +++ irix-core.c	28 Mar 2005 22:38:23 -0000
> @@ -152,7 +152,7 @@ do_sections (abfd, coreout)
>  	continue;
>  
>        if (!make_bfd_asection (abfd, secname,
> -			      SEC_ALLOC | SEC_LOAD+SEC_HAS_CONTENTS,
> +			      SEC_ALLOC | (SEC_LOAD+SEC_HAS_CONTENTS),
>  			      vmap.v_len, vmap.v_vaddr, vmap.v_offset))

This should probably be SEC_ALLOC | SEC_LOAD | SEC_HAS_CONTENTS anyways.


Thiemo

Re: [RFA] Fix compilation warnings in irix-core.c

[Eric Christopher]

On Mon, 2005-03-28 at 14:44 -0800, Joel Brobecker wrote:
> Hello,
> 
> GDB currently fails to build on mips/irix due to warnings now being
> turned into errors. I am unfortunately lacking the time to look deeply
> into this at the moment (I have asked one of my coworkers to help me
> with that), but there was one file where the fixes were I think obvious.
> Here is a patch for it:
> 
> 2005-03-28  Joel Brobecker  <brobecker@adacore.com>
> 
>         * irix-core.c (do_sections): Add parenthesis in expression
>         to avoid a compiler warning.
>         (irix_core_core_file_matches_executable_p): Add ATTRIBUTE_UNUSED
>         to unused parameters to avoid a compiler warning.


 
       if (!make_bfd_asection (abfd, secname,
-			      SEC_ALLOC | SEC_LOAD+SEC_HAS_CONTENTS,
+			      SEC_ALLOC | (SEC_LOAD+SEC_HAS_CONTENTS),

Spaces around the + please.

 irix_core_core_file_matches_executable_p (core_bfd, exec_bfd)
-     bfd *core_bfd, *exec_bfd;
+     bfd *core_bfd ATTRIBUTE_UNUSED, *exec_bfd ATTRIBUTE_UNUSED;

Can you move this to:

bfd *core_bfd ATTRIBUTE_UNUSED;
bfd *exec_bfd ATTRIBUTE_UNUSED;

please?

OK with those changes. Though if you want to migrate the whole file to
ISO I'd appreciate it. For style just look at, say, elfxx-mips.c :)

-eric

Re: [RFA] Fix compilation warnings in irix-core.c

[Joel Brobecker]

> > 2005-03-28  Joel Brobecker  <brobecker@adacore.com>
> > 
> >         * irix-core.c (do_sections): Add parenthesis in expression
> >         to avoid a compiler warning.
> >         (irix_core_core_file_matches_executable_p): Add ATTRIBUTE_UNUSED
> >         to unused parameters to avoid a compiler warning.
> 
> 
>  
>        if (!make_bfd_asection (abfd, secname,
> -			      SEC_ALLOC | SEC_LOAD+SEC_HAS_CONTENTS,
> +			      SEC_ALLOC | (SEC_LOAD+SEC_HAS_CONTENTS),
> 
> Spaces around the + please.

Daniel and Thiemo suggested changing the + into a |. I will make that
change and test that, if you agree.

>  irix_core_core_file_matches_executable_p (core_bfd, exec_bfd)
> -     bfd *core_bfd, *exec_bfd;
> +     bfd *core_bfd ATTRIBUTE_UNUSED, *exec_bfd ATTRIBUTE_UNUSED;
> 
> Can you move this to:
> 
> bfd *core_bfd ATTRIBUTE_UNUSED;
> bfd *exec_bfd ATTRIBUTE_UNUSED;
> 
> please?

Sure.

> OK with those changes. Though if you want to migrate the whole file to
> ISO I'd appreciate it. For style just look at, say, elfxx-mips.c :)

Sure. I'll try to do that today.

Thanks all three of you for the light-speed reviews.
-- 
Joel

Re: [RFA] Fix compilation warnings in irix-core.c

[Eric Christopher]

> > Spaces around the + please.
> 
> Daniel and Thiemo suggested changing the + into a |. I will make that
> change and test that, if you agree.
> 

I do. Don't forget the spacing :)

> >  irix_core_core_file_matches_executable_p (core_bfd, exec_bfd)
> > -     bfd *core_bfd, *exec_bfd;
> > +     bfd *core_bfd ATTRIBUTE_UNUSED, *exec_bfd ATTRIBUTE_UNUSED;
> > 
> > Can you move this to:
> > 
> > bfd *core_bfd ATTRIBUTE_UNUSED;
> > bfd *exec_bfd ATTRIBUTE_UNUSED;
> > 
> > please?
> 
> Sure.
> 
> > OK with those changes. Though if you want to migrate the whole file to
> > ISO I'd appreciate it. For style just look at, say, elfxx-mips.c :)
> 
> Sure. I'll try to do that today.
> 

Excellent.

-eric

Re: [RFA] Fix compilation warnings in irix-core.c

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

Here is what I just checked in:

2005-03-28  Joel Brobecker  <brobecker@adacore.com>

        * irix-core.c (do_sections): Replace + by | in expression.
        (irix_core_core_file_matches_executable_p): Add ATTRIBUTE_UNUSED
        to unused parameters to avoid a compiler warning.

Tested on mips-irix by running the GDB testsuite. I got identical
results, as expected.

Next is ISO-ification...

Thanks,
-- 
Joel

[-- Attachment #2: irix-core.c.diff --]
[-- Type: text/plain, Size: 857 bytes --]

Index: irix-core.c
===================================================================
RCS file: /cvs/src/src/bfd/irix-core.c,v
retrieving revision 1.12
diff -u -p -r1.12 irix-core.c
--- irix-core.c	24 Jun 2004 04:46:24 -0000	1.12
+++ irix-core.c	29 Mar 2005 04:17:38 -0000
@@ -152,7 +152,7 @@ do_sections (abfd, coreout)
 	continue;
 
       if (!make_bfd_asection (abfd, secname,
-			      SEC_ALLOC | SEC_LOAD+SEC_HAS_CONTENTS,
+			      SEC_ALLOC | SEC_LOAD | SEC_HAS_CONTENTS,
 			      vmap.v_len, vmap.v_vaddr, vmap.v_offset))
 	/* Fail.  */
 	return 0;
@@ -288,7 +288,8 @@ irix_core_core_file_failing_signal (abfd
 
 static bfd_boolean
 irix_core_core_file_matches_executable_p (core_bfd, exec_bfd)
-     bfd *core_bfd, *exec_bfd;
+     bfd *core_bfd ATTRIBUTE_UNUSED;
+     bfd *exec_bfd ATTRIBUTE_UNUSED;
 {
   return TRUE;			/* XXX - FIXME */
 }