From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-39189-listarch-binutils=sources.redhat.com@sources.redhat.com>
Received: (qmail 1568 invoked by alias); 29 Mar 2005 04:21:22 -0000
Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/binutils/>
List-Post: <mailto:binutils@sources.redhat.com>
List-Help: <mailto:binutils-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: binutils-owner@sources.redhat.com
Received: (qmail 1532 invoked from network); 29 Mar 2005 04:21:14 -0000
Received: from unknown (HELO priv-edtnes51.telusplanet.net) (199.185.220.223)
  by sourceware.org with SMTP; 29 Mar 2005 04:21:14 -0000
Received: from takamaka.act-europe.fr ([142.179.108.108])
          by priv-edtnes51.telusplanet.net
          (InterMail vM.6.01.04.00 201-2131-118-20041027) with ESMTP
          id <20050329042113.VRNK9877.priv-edtnes51.telusplanet.net@takamaka.act-europe.fr>;
          Mon, 28 Mar 2005 21:21:13 -0700
Received: by takamaka.act-europe.fr (Postfix, from userid 507)
	id EC9C547DC0; Mon, 28 Mar 2005 20:21:12 -0800 (PST)
Date: Tue, 29 Mar 2005 08:31:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Eric Christopher <echristo@redhat.com>
Cc: binutils@sources.redhat.com
Subject: Re: [RFA] Fix compilation warnings in irix-core.c
Message-ID: <20050329042112.GB2545@adacore.com>
References: <20050328224444.GS2295@adacore.com> <1112050439.5223.11.camel@localhost.localdomain> <20050328233959.GS2545@adacore.com> <1112053626.5223.13.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="+nBD6E3TurpgldQp"
Content-Disposition: inline
In-Reply-To: <1112053626.5223.13.camel@localhost.localdomain>
User-Agent: Mutt/1.4i
X-SW-Source: 2005-03/txt/msg00839.txt.bz2


--+nBD6E3TurpgldQp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-length: 417

Here is what I just checked in:

2005-03-28  Joel Brobecker  <brobecker@adacore.com>

        * irix-core.c (do_sections): Replace + by | in expression.
        (irix_core_core_file_matches_executable_p): Add ATTRIBUTE_UNUSED
        to unused parameters to avoid a compiler warning.

Tested on mips-irix by running the GDB testsuite. I got identical
results, as expected.

Next is ISO-ification...

Thanks,
-- 
Joel

--+nBD6E3TurpgldQp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="irix-core.c.diff"
Content-length: 857

Index: irix-core.c
===================================================================
RCS file: /cvs/src/src/bfd/irix-core.c,v
retrieving revision 1.12
diff -u -p -r1.12 irix-core.c
--- irix-core.c	24 Jun 2004 04:46:24 -0000	1.12
+++ irix-core.c	29 Mar 2005 04:17:38 -0000
@@ -152,7 +152,7 @@ do_sections (abfd, coreout)
 	continue;
 
       if (!make_bfd_asection (abfd, secname,
-			      SEC_ALLOC | SEC_LOAD+SEC_HAS_CONTENTS,
+			      SEC_ALLOC | SEC_LOAD | SEC_HAS_CONTENTS,
 			      vmap.v_len, vmap.v_vaddr, vmap.v_offset))
 	/* Fail.  */
 	return 0;
@@ -288,7 +288,8 @@ irix_core_core_file_failing_signal (abfd
 
 static bfd_boolean
 irix_core_core_file_matches_executable_p (core_bfd, exec_bfd)
-     bfd *core_bfd, *exec_bfd;
+     bfd *core_bfd ATTRIBUTE_UNUSED;
+     bfd *exec_bfd ATTRIBUTE_UNUSED;
 {
   return TRUE;			/* XXX - FIXME */
 }

--+nBD6E3TurpgldQp--