Re: [PATCH-RFC] Testcase(s) for VAX' new -M entry:0xf00 feature

[Jan-Benedict Glaw <jbglaw@microdata-pos.de>]

On Tue, Mar 29, 2005 at 05:19:52PM +0100, Nick Clifton wrote:
> Hi Jan-Benedict,
> 
>    I have checked your new VAX test patch into the CVS repository.

Thanks!

> > - Also add a -M entry:0x... for label2 (which I'd prefer to do)
> 
> I think that I would prefer this approach as well.

Here's the patch. Passes cross-build/hosted on my PC for vax-linux,
vax-ultrix, vax-netbsd and vax-netbsdelf.

2005-03-29  Jan-Benedict Glaw  <jbglaw@lug-owl.>

	binutils/testsuite/binutils-all/vax/
	* objdump.exp: Condense the two tests into one and add a
	"-m entry:" for the second label.

diff -Nurp src-fresh/binutils/testsuite/binutils-all/vax/objdump.exp src-hacked/binutils/testsuite/binutils-all/vax/objdump.exp
--- src-fresh/binutils/testsuite/binutils-all/vax/objdump.exp	2005-03-29 18:13:48.000000000 +0200
+++ src-hacked/binutils/testsuite/binutils-all/vax/objdump.exp	2005-03-29 23:03:07.000000000 +0200
@@ -45,11 +45,12 @@ if [is_remote host] {
 }
 
 #
-# First run. We expect the function to be a function and the sole label
-# not to produce an entry mask.
+# We check both function entry points. The second one at offset 2 will
+# show up automatically on ELF targets, but needs to be set on a.out
+# targets.
 #
-set got [binutils_run $OBJDUMP "$OBJDUMPFLAGS -d $objfile"]
-set want1 "\[ 	\]+0:\[ 	\]+10 01\[ 	\]+bsbb 3"
+set got [binutils_run $OBJDUMP "$OBJDUMPFLAGS -d -M entry:0x0 -M entry:2 $objfile"]
+set want1 "\[ 	\]+0:\[ 	\]+10 01\[ 	\]+\\.word 0x0110.\*r8 r4"
 set want2 "\[ 	\]+2:\[ 	\]+24 02\[ 	\]+\\.word 0x0224.\*r9 r5 r2"
 if [regexp $want1 $got] then {
     pass "entrymask test 1"
@@ -62,21 +63,3 @@ if [regexp $want2 $got] then {
     fail "entrymask test 2"
 }
 
-#
-# Second run. Now, we force the label as a function, so we expect that
-# it also produces an entry mask, as any call'able function should.
-#
-set got [binutils_run $OBJDUMP "$OBJDUMPFLAGS -d -M entry:0x0 $objfile"]
-set want3 "\[ 	\]+0:\[ 	\]+10 01\[ 	\]+\\.word 0x0110.\*r8 r4"
-set want4 "\[ 	\]+2:\[ 	\]+24 02\[ 	\]+\\.word 0x0224.\*r9 r5 r2"
-if [regexp $want3 $got] then {
-    pass "entrymask test 3"
-} else {
-    fail "entrymask test 3"
-}
-if [regexp $want4 $got] then {
-    pass "entrymask test 4"
-} else {
-    fail "entrymask test 4"
-}
-

MfG, JBG

-- 
AWEK microdata GmbH -- Am Wellbach 4 -- 33609 Bielefeld