From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15920 invoked by alias); 29 Mar 2005 21:11:56 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 15899 invoked from network); 29 Mar 2005 21:11:52 -0000 Received: from unknown (HELO imail.microdata-pos.de) (212.202.104.142) by sourceware.org with SMTP; 29 Mar 2005 21:11:52 -0000 Received: by imail.microdata-pos.de (Postfix, from userid 1033) id 33AFB77E13; Tue, 29 Mar 2005 23:11:48 +0200 (CEST) Date: Wed, 30 Mar 2005 14:28:00 -0000 From: Jan-Benedict Glaw To: Nick Clifton Cc: binutils@sources.redhat.com Subject: Re: [PATCH-RFC] Testcase(s) for VAX' new -M entry:0xf00 feature Message-ID: <20050329231148.D17534@microdata-pos.de> References: <20050324234026.B28283@microdata-pos.de> <20050325181222.A32107@microdata-pos.de> <42498028.6000901@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <42498028.6000901@redhat.com>; from nickc@redhat.com on Tue, Mar 29, 2005 at 05:19:52PM +0100 X-SW-Source: 2005-03/txt/msg00888.txt.bz2 On Tue, Mar 29, 2005 at 05:19:52PM +0100, Nick Clifton wrote: > Hi Jan-Benedict, > > I have checked your new VAX test patch into the CVS repository. Thanks! > > - Also add a -M entry:0x... for label2 (which I'd prefer to do) > > I think that I would prefer this approach as well. Here's the patch. Passes cross-build/hosted on my PC for vax-linux, vax-ultrix, vax-netbsd and vax-netbsdelf. 2005-03-29 Jan-Benedict Glaw binutils/testsuite/binutils-all/vax/ * objdump.exp: Condense the two tests into one and add a "-m entry:" for the second label. diff -Nurp src-fresh/binutils/testsuite/binutils-all/vax/objdump.exp src-hacked/binutils/testsuite/binutils-all/vax/objdump.exp --- src-fresh/binutils/testsuite/binutils-all/vax/objdump.exp 2005-03-29 18:13:48.000000000 +0200 +++ src-hacked/binutils/testsuite/binutils-all/vax/objdump.exp 2005-03-29 23:03:07.000000000 +0200 @@ -45,11 +45,12 @@ if [is_remote host] { } # -# First run. We expect the function to be a function and the sole label -# not to produce an entry mask. +# We check both function entry points. The second one at offset 2 will +# show up automatically on ELF targets, but needs to be set on a.out +# targets. # -set got [binutils_run $OBJDUMP "$OBJDUMPFLAGS -d $objfile"] -set want1 "\[ \]+0:\[ \]+10 01\[ \]+bsbb 3" +set got [binutils_run $OBJDUMP "$OBJDUMPFLAGS -d -M entry:0x0 -M entry:2 $objfile"] +set want1 "\[ \]+0:\[ \]+10 01\[ \]+\\.word 0x0110.\*r8 r4" set want2 "\[ \]+2:\[ \]+24 02\[ \]+\\.word 0x0224.\*r9 r5 r2" if [regexp $want1 $got] then { pass "entrymask test 1" @@ -62,21 +63,3 @@ if [regexp $want2 $got] then { fail "entrymask test 2" } -# -# Second run. Now, we force the label as a function, so we expect that -# it also produces an entry mask, as any call'able function should. -# -set got [binutils_run $OBJDUMP "$OBJDUMPFLAGS -d -M entry:0x0 $objfile"] -set want3 "\[ \]+0:\[ \]+10 01\[ \]+\\.word 0x0110.\*r8 r4" -set want4 "\[ \]+2:\[ \]+24 02\[ \]+\\.word 0x0224.\*r9 r5 r2" -if [regexp $want3 $got] then { - pass "entrymask test 3" -} else { - fail "entrymask test 3" -} -if [regexp $want4 $got] then { - pass "entrymask test 4" -} else { - fail "entrymask test 4" -} - MfG, JBG -- AWEK microdata GmbH -- Am Wellbach 4 -- 33609 Bielefeld