From: Jerome Guitton <guitton@adacore.com>
To: binutils@sources.redhat.com
Subject: Re: [RFA] fix compilation warning in libiberty.h
Date: Thu, 31 Mar 2005 17:08:00 -0000 [thread overview]
Message-ID: <20050331151133.GC29503@adacore.com> (raw)
In-Reply-To: <20050331144312.GA2694@nevyn.them.org>
[-- Attachment #1: Type: text/plain, Size: 318 bytes --]
Daniel Jacobowitz (drow@false.org):
> Can't this be just AC_CHECK_DECLS(basename)?
You mean there actually is such a function? I must be *really* stupid ;-)
Removing my junk autoconf code and replacing it with a simple call to
AC_CHECK_DECLS... New patch attached, same Changelog entry! Is this one OK?
--
Jerome
[-- Attachment #2: bfdconfig.dif --]
[-- Type: text/plain, Size: 3271 bytes --]
Index: config.in
===================================================================
RCS file: /cvs/src/src/bfd/config.in,v
retrieving revision 1.20
diff -u -p -r1.20 config.in
--- config.in 30 Mar 2005 02:46:24 -0000 1.20
+++ config.in 31 Mar 2005 15:02:26 -0000
@@ -24,6 +24,9 @@
/* Define to 1 if you have the `dcgettext' function. */
#undef HAVE_DCGETTEXT
+/* Define to 1 if basename is declared by the system. */
+#undef HAVE_DECL_BASENAME
+
/* Define to 1 if you have the <dirent.h> header file, and it defines `DIR'.
*/
#undef HAVE_DIRENT_H
Index: configure
===================================================================
RCS file: /cvs/src/src/bfd/configure,v
retrieving revision 1.200
diff -u -p -r1.200 configure
--- configure 30 Mar 2005 02:46:24 -0000 1.200
+++ configure 31 Mar 2005 15:02:29 -0000
@@ -9539,6 +9539,80 @@ fi
done
+echo "$as_me:$LINENO: checking whether basename is declared" >&5
+echo $ECHO_N "checking whether basename is declared... $ECHO_C" >&6
+if test "${ac_cv_have_decl_basename+set}" = set; then
+ echo $ECHO_N "(cached) $ECHO_C" >&6
+else
+ cat >conftest.$ac_ext <<_ACEOF
+/* confdefs.h. */
+_ACEOF
+cat confdefs.h >>conftest.$ac_ext
+cat >>conftest.$ac_ext <<_ACEOF
+/* end confdefs.h. */
+#include "sysdep.h"
+
+int
+main ()
+{
+#ifndef basename
+ char *p = (char *) basename;
+#endif
+
+ ;
+ return 0;
+}
+_ACEOF
+rm -f conftest.$ac_objext
+if { (eval echo "$as_me:$LINENO: \"$ac_compile\"") >&5
+ (eval $ac_compile) 2>conftest.er1
+ ac_status=$?
+ grep -v '^ *+' conftest.er1 >conftest.err
+ rm -f conftest.er1
+ cat conftest.err >&5
+ echo "$as_me:$LINENO: \$? = $ac_status" >&5
+ (exit $ac_status); } &&
+ { ac_try='test -z "$ac_c_werror_flag"
+ || test ! -s conftest.err'
+ { (eval echo "$as_me:$LINENO: \"$ac_try\"") >&5
+ (eval $ac_try) 2>&5
+ ac_status=$?
+ echo "$as_me:$LINENO: \$? = $ac_status" >&5
+ (exit $ac_status); }; } &&
+ { ac_try='test -s conftest.$ac_objext'
+ { (eval echo "$as_me:$LINENO: \"$ac_try\"") >&5
+ (eval $ac_try) 2>&5
+ ac_status=$?
+ echo "$as_me:$LINENO: \$? = $ac_status" >&5
+ (exit $ac_status); }; }; then
+ ac_cv_have_decl_basename=yes
+else
+ echo "$as_me: failed program was:" >&5
+sed 's/^/| /' conftest.$ac_ext >&5
+
+ac_cv_have_decl_basename=no
+fi
+rm -f conftest.err conftest.$ac_objext conftest.$ac_ext
+fi
+echo "$as_me:$LINENO: result: $ac_cv_have_decl_basename" >&5
+echo "${ECHO_T}$ac_cv_have_decl_basename" >&6
+if test $ac_cv_have_decl_basename = yes; then
+
+cat >>confdefs.h <<_ACEOF
+#define HAVE_DECL_BASENAME 1
+_ACEOF
+
+
+else
+ cat >>confdefs.h <<_ACEOF
+#define HAVE_DECL_BASENAME 0
+_ACEOF
+
+
+fi
+
+
+
case "${host}" in
*-*-msdos* | *-*-go32* | *-*-mingw32* | *-*-cygwin* | *-*-windows*)
Index: configure.in
===================================================================
RCS file: /cvs/src/src/bfd/configure.in,v
retrieving revision 1.172
diff -u -p -r1.172 configure.in
--- configure.in 30 Mar 2005 02:46:24 -0000 1.172
+++ configure.in 31 Mar 2005 15:02:29 -0000
@@ -162,6 +162,8 @@ AC_HEADER_DIRENT
AC_CHECK_FUNCS(fcntl getpagesize setitimer sysconf fdopen getuid getgid)
AC_CHECK_FUNCS(strtoull)
+AC_CHECK_DECLS(basename, , , [#include "sysdep.h"])
+
BFD_BINARY_FOPEN
BFD_NEED_DECLARATION(ffs)
next prev parent reply other threads:[~2005-03-31 15:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-31 15:51 Jerome Guitton
2005-03-31 16:01 ` Daniel Jacobowitz
2005-03-31 17:08 ` Jerome Guitton [this message]
2005-03-31 17:28 ` Daniel Jacobowitz
2005-03-31 17:38 ` Jerome Guitton
2005-04-22 23:03 ` Adam Nemet
2005-04-25 1:44 ` Daniel Jacobowitz
2005-04-25 4:51 ` Adam Nemet
2005-04-26 10:40 ` Jerome Guitton
2005-03-31 21:16 ` Maciej W. Rozycki
2005-03-31 23:29 ` Jerome Guitton
-- strict thread matches above, loose matches on Subject: below --
2005-03-18 19:54 [RFA] Fix " Joel Brobecker
2005-03-18 19:56 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050331151133.GC29503@adacore.com \
--to=guitton@adacore.com \
--cc=binutils@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).