From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25263 invoked by alias); 31 Mar 2005 15:11:47 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 25142 invoked from network); 31 Mar 2005 15:11:34 -0000 Received: from unknown (HELO dublin.act-europe.fr) (212.157.227.154) by sourceware.org with SMTP; 31 Mar 2005 15:11:34 -0000 Received: from localhost (province.act-europe.fr [10.10.0.214]) by filtered-dublin.act-europe.fr (Postfix) with ESMTP id 247B6229E5C for ; Thu, 31 Mar 2005 17:11:34 +0200 (MET DST) Received: from dublin.act-europe.fr ([10.10.0.154]) by localhost (province.act-europe.fr [10.10.0.214]) (amavisd-new, port 10024) with ESMTP id 67189-07 for ; Thu, 31 Mar 2005 17:11:33 +0200 (CEST) Received: from berne.act-europe.fr (berne.act-europe.fr [10.10.0.165]) by dublin.act-europe.fr (Postfix) with ESMTP id D16A7229E5B for ; Thu, 31 Mar 2005 17:11:33 +0200 (MET DST) Received: by berne.act-europe.fr (Postfix, from userid 560) id 81CA6592B; Thu, 31 Mar 2005 10:11:33 -0500 (EST) Date: Thu, 31 Mar 2005 17:08:00 -0000 From: Jerome Guitton To: binutils@sources.redhat.com Subject: Re: [RFA] fix compilation warning in libiberty.h Message-ID: <20050331151133.GC29503@adacore.com> References: <20050331132734.GA25521@adacore.com> <20050331144312.GA2694@nevyn.them.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Qz2CZ664xQdCRdPu" Content-Disposition: inline In-Reply-To: <20050331144312.GA2694@nevyn.them.org> User-Agent: Mutt/1.4i X-SW-Source: 2005-03/txt/msg00930.txt.bz2 --Qz2CZ664xQdCRdPu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 318 Daniel Jacobowitz (drow@false.org): > Can't this be just AC_CHECK_DECLS(basename)? You mean there actually is such a function? I must be *really* stupid ;-) Removing my junk autoconf code and replacing it with a simple call to AC_CHECK_DECLS... New patch attached, same Changelog entry! Is this one OK? -- Jerome --Qz2CZ664xQdCRdPu Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="bfdconfig.dif" Content-length: 3271 Index: config.in =================================================================== RCS file: /cvs/src/src/bfd/config.in,v retrieving revision 1.20 diff -u -p -r1.20 config.in --- config.in 30 Mar 2005 02:46:24 -0000 1.20 +++ config.in 31 Mar 2005 15:02:26 -0000 @@ -24,6 +24,9 @@ /* Define to 1 if you have the `dcgettext' function. */ #undef HAVE_DCGETTEXT +/* Define to 1 if basename is declared by the system. */ +#undef HAVE_DECL_BASENAME + /* Define to 1 if you have the header file, and it defines `DIR'. */ #undef HAVE_DIRENT_H Index: configure =================================================================== RCS file: /cvs/src/src/bfd/configure,v retrieving revision 1.200 diff -u -p -r1.200 configure --- configure 30 Mar 2005 02:46:24 -0000 1.200 +++ configure 31 Mar 2005 15:02:29 -0000 @@ -9539,6 +9539,80 @@ fi done +echo "$as_me:$LINENO: checking whether basename is declared" >&5 +echo $ECHO_N "checking whether basename is declared... $ECHO_C" >&6 +if test "${ac_cv_have_decl_basename+set}" = set; then + echo $ECHO_N "(cached) $ECHO_C" >&6 +else + cat >conftest.$ac_ext <<_ACEOF +/* confdefs.h. */ +_ACEOF +cat confdefs.h >>conftest.$ac_ext +cat >>conftest.$ac_ext <<_ACEOF +/* end confdefs.h. */ +#include "sysdep.h" + +int +main () +{ +#ifndef basename + char *p = (char *) basename; +#endif + + ; + return 0; +} +_ACEOF +rm -f conftest.$ac_objext +if { (eval echo "$as_me:$LINENO: \"$ac_compile\"") >&5 + (eval $ac_compile) 2>conftest.er1 + ac_status=$? + grep -v '^ *+' conftest.er1 >conftest.err + rm -f conftest.er1 + cat conftest.err >&5 + echo "$as_me:$LINENO: \$? = $ac_status" >&5 + (exit $ac_status); } && + { ac_try='test -z "$ac_c_werror_flag" + || test ! -s conftest.err' + { (eval echo "$as_me:$LINENO: \"$ac_try\"") >&5 + (eval $ac_try) 2>&5 + ac_status=$? + echo "$as_me:$LINENO: \$? = $ac_status" >&5 + (exit $ac_status); }; } && + { ac_try='test -s conftest.$ac_objext' + { (eval echo "$as_me:$LINENO: \"$ac_try\"") >&5 + (eval $ac_try) 2>&5 + ac_status=$? + echo "$as_me:$LINENO: \$? = $ac_status" >&5 + (exit $ac_status); }; }; then + ac_cv_have_decl_basename=yes +else + echo "$as_me: failed program was:" >&5 +sed 's/^/| /' conftest.$ac_ext >&5 + +ac_cv_have_decl_basename=no +fi +rm -f conftest.err conftest.$ac_objext conftest.$ac_ext +fi +echo "$as_me:$LINENO: result: $ac_cv_have_decl_basename" >&5 +echo "${ECHO_T}$ac_cv_have_decl_basename" >&6 +if test $ac_cv_have_decl_basename = yes; then + +cat >>confdefs.h <<_ACEOF +#define HAVE_DECL_BASENAME 1 +_ACEOF + + +else + cat >>confdefs.h <<_ACEOF +#define HAVE_DECL_BASENAME 0 +_ACEOF + + +fi + + + case "${host}" in *-*-msdos* | *-*-go32* | *-*-mingw32* | *-*-cygwin* | *-*-windows*) Index: configure.in =================================================================== RCS file: /cvs/src/src/bfd/configure.in,v retrieving revision 1.172 diff -u -p -r1.172 configure.in --- configure.in 30 Mar 2005 02:46:24 -0000 1.172 +++ configure.in 31 Mar 2005 15:02:29 -0000 @@ -162,6 +162,8 @@ AC_HEADER_DIRENT AC_CHECK_FUNCS(fcntl getpagesize setitimer sysconf fdopen getuid getgid) AC_CHECK_FUNCS(strtoull) +AC_CHECK_DECLS(basename, , , [#include "sysdep.h"]) + BFD_BINARY_FOPEN BFD_NEED_DECLARATION(ffs) --Qz2CZ664xQdCRdPu--