Build error at FreeBSD in gas/symbols.c

Build error at FreeBSD in gas/symbols.c

[Vladimir A. Merzliakov]

After CVS commit http://sourceware.org/ml/binutils-cvs/2005-04/msg00071.html
I can't build binutils CVS mainline at FreeBSD 5.3.

Build terminate with error message:

/usr/home/wanderer/pkg/build/binutils/src/src/gas/symbols.c: In function 
'symbol_X_add_number':
/usr/home/wanderer/pkg/build/binutils/src/src/gas/symbols.c:2035: warning: 
pointer targets in return differ in signedness
gmake[3]: *** [symbols.o] Error 1

Vladimir

Re: Build error at FreeBSD in gas/symbols.c

[Alan Modra]

On Sun, Apr 10, 2005 at 05:39:50PM +0400, Vladimir A. Merzliakov wrote:
> /usr/home/wanderer/pkg/build/binutils/src/src/gas/symbols.c:2035: warning: 
> pointer targets in return differ in signedness

Thanks.  I picked the wrong type for the function return, and missed a
needed cast.

	* symbols.c (symbol_X_add_number): Warning fixes.
	* symbols.h (symbol_X_add_number): Update prototype.

Index: gas/symbols.c
===================================================================
RCS file: /cvs/src/src/gas/symbols.c,v
retrieving revision 1.57
diff -u -p -r1.57 symbols.c
--- gas/symbols.c	9 Apr 2005 03:48:09 -0000	1.57
+++ gas/symbols.c	10 Apr 2005 23:38:16 -0000
@@ -2024,12 +2024,12 @@ symbol_set_value_expression (symbolS *s,
 
 /* Return a pointer to the X_add_number component of a symbol.  */
 
-valueT *
+offsetT *
 symbol_X_add_number (symbolS *s)
 {
 #ifdef BFD_ASSEMBLER
   if (LOCAL_SYMBOL_CHECK (s))
-    return &((struct local_symbol *) s)->lsy_value;
+    return (offsetT *) &((struct local_symbol *) s)->lsy_value;
 #endif
 
   return &s->sy_value.X_add_number;
Index: gas/symbols.h
===================================================================
RCS file: /cvs/src/src/gas/symbols.h,v
retrieving revision 1.17
diff -u -p -r1.17 symbols.h
--- gas/symbols.h	9 Apr 2005 03:48:09 -0000	1.17
+++ gas/symbols.h	10 Apr 2005 23:38:16 -0000
@@ -175,7 +175,7 @@ extern symbolS *symbol_next (symbolS *);
 
 extern expressionS *symbol_get_value_expression (symbolS *);
 extern void symbol_set_value_expression (symbolS *, const expressionS *);
-extern valueT *symbol_X_add_number (symbolS *);
+extern offsetT *symbol_X_add_number (symbolS *);
 extern void symbol_set_value_now (symbolS *);
 extern void symbol_set_frag (symbolS *, fragS *);
 extern fragS *symbol_get_frag (symbolS *);

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

Re: Build error at FreeBSD in gas/symbols.c

[Vladimir A. Merzliakov]

> On Sun, Apr 10, 2005 at 05:39:50PM +0400, Vladimir A. Merzliakov wrote:
>> /usr/home/wanderer/pkg/build/binutils/src/src/gas/symbols.c:2035: 
>> warning:
>> pointer targets in return differ in signedness
>
> Thanks.  I picked the wrong type for the function return, and missed a
> needed cast.
>
> * symbols.c (symbol_X_add_number): Warning fixes.
> * symbols.h (symbol_X_add_number): Update prototype.
>
Build fine now :)

Thank you for fixing!

Vladimir