From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-39585-listarch-binutils=sources.redhat.com@sources.redhat.com>
Received: (qmail 25894 invoked by alias); 12 Apr 2005 11:41:46 -0000
Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/binutils/>
List-Post: <mailto:binutils@sources.redhat.com>
List-Help: <mailto:binutils-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: binutils-owner@sources.redhat.com
Received: (qmail 25724 invoked from network); 12 Apr 2005 11:41:41 -0000
Received: from unknown (HELO gizmo08ps.bigpond.com) (144.140.71.18)
  by sourceware.org with SMTP; 12 Apr 2005 11:41:41 -0000
Received: (qmail 27732 invoked from network); 12 Apr 2005 11:41:39 -0000
Received: from unknown (HELO psmam12.bigpond.com) (144.135.25.103)
  by gizmo08ps.bigpond.com with SMTP; 12 Apr 2005 11:41:39 -0000
Received: from cpe-144-136-221-26.sa.bigpond.net.au ([144.136.221.26]) by psmam12.bigpond.com(MAM REL_3_4_2a 234/10688689) with SMTP id 10688689; Tue, 12 Apr 2005 21:41:39 +1000
Received: by bubble.modra.org (Postfix, from userid 500)
	id 1B8521A6F20; Tue, 12 Apr 2005 21:11:39 +0930
Date: Tue, 12 Apr 2005 11:41:00 -0000
From: Alan Modra <amodra@bigpond.net.au>
To: Nick Clifton <nickc@redhat.com>
Cc: "H. J. Lu" <hjl@lucon.org>, binutils@sources.redhat.com
Subject: Re: housekeeping, -Wno-error
Message-ID: <20050412114139.GF3321@bubble.modra.org>
Mail-Followup-To: Nick Clifton <nickc@redhat.com>,
	"H. J. Lu" <hjl@lucon.org>, binutils@sources.redhat.com
References: <20050412025055.GC3321@bubble.modra.org> <20050412043621.GA27008@lucon.org> <20050412054212.GD3321@bubble.modra.org> <425B8860.6050403@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <425B8860.6050403@redhat.com>
User-Agent: Mutt/1.4i
X-SW-Source: 2005-04/txt/msg00285.txt.bz2

On Tue, Apr 12, 2005 at 09:35:44AM +0100, Nick Clifton wrote:
> configure files.  In the meantime however I was about to apply a 
> Makefile based patch like this:

I've been playing with the following, along with Makefile.am changes
to use $(NO_WERROR) in place of -Wno-error.  The idea is to put this
some place so that all the configure.in can use a common definition
for warnings.  I've changed it so that --enable-werror and
--enable-build-warnings should be usable with compilers other than
gcc.

AC_DEFUN([AM_BINUTILS_WARNINGS],[
WARN_CFLAGS="-W -Wall -Wstrict-prototypes -Wmissing-prototypes"

AC_ARG_ENABLE(werror,
  [  --enable-werror    treat compile warnings as errors],
  [case "${enableval}" in
     yes | y) ERROR_ON_WARNING="yes" ;;
     no | n)  ERROR_ON_WARNING="no" ;;
     *) AC_MSG_ERROR(bad value ${enableval} for --enable-werror) ;;
   esac])

# Enable -Werror by default when using gcc
if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then
    ERROR_ON_WARNING=yes
fi

NO_WERROR=
if test "${ERROR_ON_WARNING}" = yes ; then
    WARN_CFLAGS="$WARN_CFLAGS -Werror"
    NO_WERROR="-Wno-error"
fi
		   
AC_ARG_ENABLE(build-warnings,
[  --enable-build-warnings Enable build-time compiler warnings],
[case "${enableval}" in
  yes)	;;
  no)	WARN_CFLAGS="-w";;
  ,*)   t=`echo "${enableval}" | sed -e "s/,/ /g"`
        WARN_CFLAGS="${WARN_CFLAGS} ${t}";;
  *,)   t=`echo "${enableval}" | sed -e "s/,/ /g"`
        WARN_CFLAGS="${t} ${WARN_CFLAGS}";;
  *)    WARN_CFLAGS=`echo "${enableval}" | sed -e "s/,/ /g"`;;
esac])

if test x"$silent" != x"yes" && test x"$WARN_CFLAGS" != x""; then
  echo "Setting warning flags = $WARN_CFLAGS" 6>&1
fi

AC_SUBST(WARN_CFLAGS)
AC_SUBST(NO_WERROR)
])


-- 
Alan Modra
IBM OzLabs - Linux Technology Centre