From: "Kaveh R. Ghazi" <ghazi@caip.rutgers.edu>
To: binutils@sources.redhat.com, gcc-patches@gcc.gnu.org
Cc: amodra@bigpond.net.au, dj@redhat.com, ian@airs.com
Subject: Remove parameter names from libiberty.h
Date: Wed, 13 Apr 2005 23:57:00 -0000 [thread overview]
Message-ID: <200504132357.j3DNvcF1028534@caip.rutgers.edu> (raw)
In-Reply-To: <20050412012121.GA3321@bubble.modra.org>
As noted here:
http://sourceware.org/ml/binutils/2005-04/msg00269.html
The new f*open_unlocked function prototypes in libiberty.h are in
conflict with binutils sources because one of the parameter names
("mode") gets defined to "31" and the build dies.
Personally, I like parameter names as documentation, and I'd recommend
moving the inclusion of libiberty.h higher in opcodes/m88k-dis.c so
that "mode" isn't clobbered by the time we get these prototypes, but
it's not worth arguing over IMO.
So here's a patch to do as Alan asked. Let me know if I should
install it.
--Kaveh
2005-04-13 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
* libiberty.h (fopen_unlocked, fdopen_unlocked, freopen_unlocked):
Remove parameter names.
diff -rup orig/egcc-CVS20050413/include/libiberty.h egcc-CVS20050413/include/libiberty.h
--- orig/egcc-CVS20050413/include/libiberty.h 2005-04-13 19:33:34.502555400 -0400
+++ egcc-CVS20050413/include/libiberty.h 2005-04-13 19:34:12.465784112 -0400
@@ -52,9 +52,9 @@ extern "C" {
the stream is setup to avoid any multi-threaded locking. Otherwise
return the FILE pointer unchanged. */
-extern FILE *fopen_unlocked (const char *path, const char *mode);
-extern FILE *fdopen_unlocked (int fildes, const char *mode);
-extern FILE *freopen_unlocked (const char *path, const char *mode, FILE *stream);
+extern FILE *fopen_unlocked (const char *, const char *);
+extern FILE *fdopen_unlocked (int, const char *);
+extern FILE *freopen_unlocked (const char *, const char *, FILE *);
/* Build an argument vector from a string. Allocates memory using
malloc. Use freeargv to free the vector. */
next prev parent reply other threads:[~2005-04-13 23:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-12 1:21 libiberty.h Alan Modra
2005-04-13 23:57 ` Kaveh R. Ghazi [this message]
2005-04-14 1:13 ` Remove parameter names from libiberty.h Ian Lance Taylor
2005-04-14 7:42 ` Thorsten Glaser
2005-04-14 12:41 ` DJ Delorie
2005-04-14 10:20 Marc Espie
2005-04-15 7:34 ` Thorsten Glaser
2005-04-14 15:21 Paul Schlie
2005-04-14 16:18 ` Andrew Pinski
2005-04-14 17:18 ` H. J. Lu
2005-04-14 17:50 ` Dave Korn
2005-04-14 20:58 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200504132357.j3DNvcF1028534@caip.rutgers.edu \
--to=ghazi@caip.rutgers.edu \
--cc=amodra@bigpond.net.au \
--cc=binutils@sources.redhat.com \
--cc=dj@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ian@airs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).