From: "H. J. Lu" <hjl@lucon.org>
To: Andrew Pinski <pinskia@physics.uc.edu>
Cc: Paul Schlie <schlie@comcast.net>,
"Kaveh R. Ghazi" <ghazi@caip.rutgers.edu>,
binutils@sources.redhat.com, gcc-patches@gcc.gnu.org,
amodra@bigpond.net.au, dj@redhat.com,
Ian Lance Taylor <ian@airs.com>
Subject: Re: Remove parameter names from libiberty.h
Date: Thu, 14 Apr 2005 17:18:00 -0000 [thread overview]
Message-ID: <20050414171804.GA21615@lucon.org> (raw)
In-Reply-To: <200504141617.j3EGHBFt014053@earth.phy.uc.edu>
On Thu, Apr 14, 2005 at 12:17:11PM -0400, Andrew Pinski wrote:
> >
> > > Kaveh R. Ghazi writes:
> > > As noted here:
> > > http://sourceware.org/ml/binutils/2005-04/msg00269.html
> > >
> > > The new f*open_unlocked function prototypes in libiberty.h are in
> > > conflict with binutils sources because one of the parameter names
> > > ("mode") gets defined to "31" and the build dies.
> >
> > Why not alternatively fix the real problem (as you had noted), as opposed to
> > indirectly establishing the policy that libiberty prototypes don't include
> > parameter names (as it doesn't seem like the true solution to the problem).
>
> I don't know why I am replying to you but ...
> Anyways there is no other way to fix the problem correctly. If we change
> the parameter name, someone else might have defined it so we get into
> a cycle.
>
There are many prototypes in libiberty.h with names.
H.J.
next prev parent reply other threads:[~2005-04-14 17:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-14 15:21 Paul Schlie
2005-04-14 16:18 ` Andrew Pinski
2005-04-14 17:18 ` H. J. Lu [this message]
2005-04-14 17:50 ` Dave Korn
2005-04-14 20:58 ` Ian Lance Taylor
-- strict thread matches above, loose matches on Subject: below --
2005-04-14 10:20 Marc Espie
2005-04-15 7:34 ` Thorsten Glaser
2005-04-12 1:21 libiberty.h Alan Modra
2005-04-13 23:57 ` Remove parameter names from libiberty.h Kaveh R. Ghazi
2005-04-14 1:13 ` Ian Lance Taylor
2005-04-14 7:42 ` Thorsten Glaser
2005-04-14 12:41 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050414171804.GA21615@lucon.org \
--to=hjl@lucon.org \
--cc=amodra@bigpond.net.au \
--cc=binutils@sources.redhat.com \
--cc=dj@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ghazi@caip.rutgers.edu \
--cc=ian@airs.com \
--cc=pinskia@physics.uc.edu \
--cc=schlie@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).