From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-39683-listarch-binutils=sources.redhat.com@sources.redhat.com>
Received: (qmail 27042 invoked by alias); 14 Apr 2005 17:18:11 -0000
Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/binutils/>
List-Post: <mailto:binutils@sources.redhat.com>
List-Help: <mailto:binutils-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: binutils-owner@sources.redhat.com
Received: (qmail 26787 invoked from network); 14 Apr 2005 17:18:05 -0000
Received: from unknown (HELO sccrmhc14.comcast.net) (204.127.202.59)
  by sourceware.org with SMTP; 14 Apr 2005 17:18:05 -0000
Received: from lucon.org ([24.6.212.230]) by comcast.net (sccrmhc14) with ESMTP
          id <2005041417180401400g6v2ue>; Thu, 14 Apr 2005 17:18:05 +0000
Received: by lucon.org (Postfix, from userid 1000)
	id 6121763F44; Thu, 14 Apr 2005 10:18:04 -0700 (PDT)
Date: Thu, 14 Apr 2005 17:18:00 -0000
From: "H. J. Lu" <hjl@lucon.org>
To: Andrew Pinski <pinskia@physics.uc.edu>
Cc: Paul Schlie <schlie@comcast.net>,
	"Kaveh R. Ghazi" <ghazi@caip.rutgers.edu>,
	binutils@sources.redhat.com, gcc-patches@gcc.gnu.org,
	amodra@bigpond.net.au, dj@redhat.com, Ian Lance Taylor <ian@airs.com>
Subject: Re: Remove parameter names from libiberty.h
Message-ID: <20050414171804.GA21615@lucon.org>
References: <BE8402CB.9CF2%schlie@comcast.net> <200504141617.j3EGHBFt014053@earth.phy.uc.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200504141617.j3EGHBFt014053@earth.phy.uc.edu>
User-Agent: Mutt/1.4.1i
X-SW-Source: 2005-04/txt/msg00383.txt.bz2

On Thu, Apr 14, 2005 at 12:17:11PM -0400, Andrew Pinski wrote:
> > 
> > > Kaveh R. Ghazi writes:
> > > As noted here:
> > > http://sourceware.org/ml/binutils/2005-04/msg00269.html
> > > 
> > > The new f*open_unlocked function prototypes in libiberty.h are in
> > > conflict with binutils sources because one of the parameter names
> > > ("mode") gets defined to "31" and the build dies.
> > 
> > Why not alternatively fix the real problem (as you had noted), as opposed to
> > indirectly establishing the policy that libiberty prototypes don't include
> > parameter names (as it doesn't seem like the true solution to the problem).
> 
> I don't know why I am replying to you but ...
> Anyways there is no other way to fix the problem correctly.  If we change
> the parameter name, someone else might have defined it so we get into
> a cycle.
> 

There are many prototypes in libiberty.h with names.


H.J.