Re: RFA: Adjust MIPS hidden symbol handling

[Daniel Jacobowitz <drow@false.org>]

On Wed, Apr 13, 2005 at 07:21:16PM +0200, Thiemo Seufer wrote:
> Daniel Jacobowitz wrote:
> [snip]
> > 2005-04-13  Daniel Jacobowitz  <dan@codesourcery.com>
> > 
> > 	* elfxx-mips.c (struct mips_got_entry): Update comment.
> > 	(struct mips_elf_link_hash_entry): Remove forced_local.
> > 	(mips_elf_link_hash_newfunc): Don't initialize forced_local.
> > 	(mips_elf_create_local_got_entry): Check h->root.forced_local
> > 	instead.
> > 	(mips_elf_make_got_per_bfd): Likewise.
> > 	(_bfd_mips_elf_hide_symbol): Likewise.  Don't set forced_local.
> 
> Ok.

Unfortunately, not.

I still think the patch is right in principle, and without it I get all
sorts of assertion failures - but with it, I don't get enough room
allocated for local GOT entries.

What I think is happening is that without the patch, several kinds of
hidden symbols are given unnecessary (and probably undesirable) global
GOT entries.  With it, they're given local GOT entries - but something
else needs to be adjusted to account for it.

I'm going to keep looking into this :-(  I'd _like_ to fix it for 2.16,
but 2.16 is running late already.

-- 
Daniel Jacobowitz
CodeSourcery, LLC