public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* PATCH: PR 855: objcopy creates invalid object
@ 2005-04-16 23:23 H. J. Lu
  2005-04-18  2:37 ` Alan Modra
  0 siblings, 1 reply; 2+ messages in thread
From: H. J. Lu @ 2005-04-16 23:23 UTC (permalink / raw)
  To: binutils

This is the second part of the patch to fix PR 855.


H.J.
----
2005-04-16  H.J. Lu  <hongjiu.lu@intel.com>

	PR 855
	* elf.c (_bfd_elf_copy_private_section_data): Don't copy linker
	created group data.

--- bfd/elf.c.fake	2005-04-16 14:55:12.000000000 -0700
+++ bfd/elf.c	2005-04-16 16:16:21.000000000 -0700
@@ -5578,9 +5578,14 @@ _bfd_elf_copy_private_section_data (bfd 
 
   /* Set things up for objcopy.  The output SHT_GROUP section will
      have its elf_next_in_group pointing back to the input group
-     members.  */
-  elf_next_in_group (osec) = elf_next_in_group (isec);
-  elf_group_name (osec) = elf_group_name (isec);
+     members.  Ignore linker created group section.  See
+     elfNN_ia64_object_p in elfxx-ia64.c.  */
+  if (elf_sec_group (isec) == NULL
+      || (elf_sec_group (isec)->flags & SEC_LINKER_CREATED) == 0)
+    {
+      elf_next_in_group (osec) = elf_next_in_group (isec);
+      elf_group_name (osec) = elf_group_name (isec);
+    }
 
   osec->use_rela_p = isec->use_rela_p;
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: PATCH: PR 855: objcopy creates invalid object
  2005-04-16 23:23 PATCH: PR 855: objcopy creates invalid object H. J. Lu
@ 2005-04-18  2:37 ` Alan Modra
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Modra @ 2005-04-18  2:37 UTC (permalink / raw)
  To: H. J. Lu; +Cc: binutils

On Sat, Apr 16, 2005 at 04:23:22PM -0700, H. J. Lu wrote:
> 	PR 855
> 	* elf.c (_bfd_elf_copy_private_section_data): Don't copy linker
> 	created group data.

OK.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-04-18  2:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-04-16 23:23 PATCH: PR 855: objcopy creates invalid object H. J. Lu
2005-04-18  2:37 ` Alan Modra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).