public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "H. J. Lu" <hjl@lucon.org>
To: Jan Beulich <JBeulich@novell.com>
Cc: amodra@bigpond.net.au, nickc@redhat.com,
	binutils@sources.redhat.com, wilson@specifixinc.com
Subject: Re: [PATCH] ELF: make .struct interact with .previous
Date: Mon, 18 Apr 2005 13:47:00 -0000	[thread overview]
Message-ID: <20050418134706.GA12846@lucon.org> (raw)
In-Reply-To: <s2637663.086@emea1-mh.id2.novell.com>

On Mon, Apr 18, 2005 at 09:57:19AM +0200, Jan Beulich wrote:
> >>> Alan Modra <amodra@bigpond.net.au> 18.04.05 01:34:05 >>>
> >The struct test is using a .short, which looks like a data allocation
> >pseudo-op to me.  If .short should have different alignment when you
> >happen to use it in the absolute section, then md_cons_align should
> >reflect that fact.
> 
> I agree to this; therefore I'd suggest the below adjustment to the test.
> 
> Jan
> 
> gas/testsuite/
> 2005-04-15  Jan Beulich  <jbeulich@novell.com>
> 
> 	* gas/elf/struct.s: Adjust to not get into alignment issues.
> 	* gas/elf/struct.d: Adjust for the above and the test's name.
> 

You are assuming .short will be aligned at 2. The example in document
has

            .struct 0
     field1:
             .struct field1 + 4
     field2:
             .struct field2 + 4
     field3:


H.J.

  reply	other threads:[~2005-04-18 13:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-18  7:57 Jan Beulich
2005-04-18 13:47 ` H. J. Lu [this message]
2005-04-18 20:12 ` James E Wilson
2005-04-19 21:27   ` H. J. Lu
  -- strict thread matches above, loose matches on Subject: below --
2005-04-20  7:12 Jan Beulich
2005-04-20  9:31 ` Nick Clifton
2005-04-18 14:13 Jan Beulich
2005-04-13 13:41 Jan Beulich
2005-04-15 10:52 ` Nick Clifton
2005-04-15 17:31   ` H. J. Lu
2005-04-15 18:37     ` H. J. Lu
2005-04-15 22:00       ` Alan Modra
2005-04-16  0:36         ` H. J. Lu
2005-04-16  0:44           ` H. J. Lu
2005-04-17 23:34             ` Alan Modra
2005-04-18  1:15               ` H. J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050418134706.GA12846@lucon.org \
    --to=hjl@lucon.org \
    --cc=JBeulich@novell.com \
    --cc=amodra@bigpond.net.au \
    --cc=binutils@sources.redhat.com \
    --cc=nickc@redhat.com \
    --cc=wilson@specifixinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).