From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22384 invoked by alias); 18 Apr 2005 13:47:17 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 22325 invoked from network); 18 Apr 2005 13:47:08 -0000 Received: from unknown (HELO sccrmhc12.comcast.net) (204.127.202.56) by sourceware.org with SMTP; 18 Apr 2005 13:47:08 -0000 Received: from lucon.org ([24.6.212.230]) by comcast.net (sccrmhc12) with ESMTP id <200504181347070120053u0fe>; Mon, 18 Apr 2005 13:47:07 +0000 Received: by lucon.org (Postfix, from userid 1000) id B742863F44; Mon, 18 Apr 2005 06:47:06 -0700 (PDT) Date: Mon, 18 Apr 2005 13:47:00 -0000 From: "H. J. Lu" To: Jan Beulich Cc: amodra@bigpond.net.au, nickc@redhat.com, binutils@sources.redhat.com, wilson@specifixinc.com Subject: Re: [PATCH] ELF: make .struct interact with .previous Message-ID: <20050418134706.GA12846@lucon.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-SW-Source: 2005-04/txt/msg00478.txt.bz2 On Mon, Apr 18, 2005 at 09:57:19AM +0200, Jan Beulich wrote: > >>> Alan Modra 18.04.05 01:34:05 >>> > >The struct test is using a .short, which looks like a data allocation > >pseudo-op to me. If .short should have different alignment when you > >happen to use it in the absolute section, then md_cons_align should > >reflect that fact. > > I agree to this; therefore I'd suggest the below adjustment to the test. > > Jan > > gas/testsuite/ > 2005-04-15 Jan Beulich > > * gas/elf/struct.s: Adjust to not get into alignment issues. > * gas/elf/struct.d: Adjust for the above and the test's name. > You are assuming .short will be aligned at 2. The example in document has .struct 0 field1: .struct field1 + 4 field2: .struct field2 + 4 field3: H.J.